Fix: scrollbar placement in Node Inspector#985
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the Node Inspector page layout so the vertical scrollbar is attached to a full-width container rather than the centered, max-width content column—addressing scrollbar placement in the debugger UI. It also removes a couple of unused test aliases.
Changes:
- Move the Node Inspector’s
overflow-y-autoscrolling behavior to a full-width wrapper div and center content via an innermax-w-screen-2xl mx-autocontainer. - Remove unused
LiveDebugger.Utils.Versionsaliases from two callback tracer test modules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/services/callback_tracer/gen_servers/tracing_manager_test.exs | Removes an unused alias to reduce warnings/unused imports. |
| test/services/callback_tracer/actions/tracing_test.exs | Removes an unused alias to reduce warnings/unused imports. |
| lib/live_debugger/app/debugger/web/components/pages.ex | Updates Node Inspector layout structure so the scrollbar is on a full-width container while content remains centered. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.