Skip to content

Fix: scrollbar placement in Node Inspector #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhubert6 merged 1 commit into from
May 4, 2026
Merged

Fix: scrollbar placement in Node Inspector #985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 40 additions & 38 deletions lib/live_debugger/app/debugger/web/components/pages.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,44 +47,46 @@ defmodule LiveDebugger.App.Debugger.Web.Components.Pages do
dropdown_id="node-inspector"
/>

<div class="flex flex-col max-w-screen-2xl w-full gap-4 p-8 overflow-y-auto">
<.live_component
module={NodeBasicInfo}
id="node-inspector-basic-info"
lv_process={@lv_process}
node_id={@node_id}
/>

<NodeStateLive.live_render
id="node-state-lv"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>

<AsyncJobsLive.live_render
id="async-jobs-lv"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>
<StreamsLive.live_render
id="streams-list"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>

<CallbackTracingWeb.NodeTracesLive.live_render
id="traces-list"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>
<div class="w-full overflow-y-auto">
<div class="flex flex-col max-w-screen-2xl w-full gap-4 p-8 mx-auto">
<.live_component
module={NodeBasicInfo}
id="node-inspector-basic-info"
lv_process={@lv_process}
node_id={@node_id}
/>

<NodeStateLive.live_render
id="node-state-lv"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>

<AsyncJobsLive.live_render
id="async-jobs-lv"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>
<StreamsLive.live_render
id="streams-list"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>

<CallbackTracingWeb.NodeTracesLive.live_render
id="traces-list"
class="flex"
socket={@socket}
lv_process={@lv_process}
node_id={@node_id}
/>
</div>
</div>
</div>
<.live_component module={NodeInspectorSidebar} id={@sidebar_id} trigger_sidebar={@trigger_sidebar}>
Expand Down
1 change: 0 additions & 1 deletion test/services/callback_tracer/actions/tracing_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ defmodule LiveDebugger.Services.CallbackTracer.Actions.TracingTest do
alias LiveDebugger.MockBus
alias LiveDebugger.Services.CallbackTracer.Actions.Tracing, as: TracingActions
alias LiveDebugger.Services.CallbackTracer.Events.DbgStarted
alias LiveDebugger.Utils.Versions

setup :verify_on_exit!

Expand Down
1 change: 0 additions & 1 deletion test/services/callback_tracer/gen_servers/tracing_manager_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ defmodule LiveDebugger.Services.CallbackTracer.GenServers.TracingManagerTest do
alias LiveDebugger.Services.CallbackTracer.Events.DbgStarted
alias LiveDebugger.Services.CallbackTracer.GenServers.TracingManager
alias LiveDebugger.Services.ProcessMonitor.Events.LiveViewBorn
alias LiveDebugger.Utils.Versions

setup :verify_on_exit!

Expand Down
Loading