Merge branch 'main' into @ksienkiewicz/fix-link-copy-pasting

Author: hejsztynx

.github/PULL_REQUEST_TEMPLATE.md

@@ -29,6 +29,7 @@ Include any visual proof that helps reviewers understand the change — UI updat
 | ------- | :---------: |
 | iOS     |    ✅❌     |
 | Android |    ✅❌     |
+| Web     |    ✅❌     |
 
 ## Checklist
 

.github/workflows/ci.yml

@@ -205,7 +205,7 @@ jobs:
       - name: Set up Xcode
         uses: maxim-lobanov/setup-xcode@v1
         with:
-          xcode-version: '16.4'
+          xcode-version: '26.6'
 
       - name: Reset build folder and pods
         run: rm -rf apps/example/build apps/example/ios/Pods apps/example/ios/Podfile.lock

.maestro/enrichedInput/screenshots/android/codeblock_no_link_detection.png

@@ -77,6 +77,7 @@ until adb -s "$SERIAL" shell getprop sys.boot_completed 2>/dev/null | grep -q "^
 done
 
 adb -s "$SERIAL" shell pm disable-user --user 0 com.google.android.inputmethod.latin
+adb -s "$SERIAL" shell settings put secure spell_checker_enabled 0
 
 echo "Emulator ready: $AVD_NAME ($SERIAL)"
 echo "DEVICE_ID=$SERIAL"

.maestro/enrichedInput/screenshots/android/codeblock_style_blocking.png

@@ -25,6 +25,21 @@ if [ -z "$UDID" ]; then
   exit 1
 fi
 
+# disable automatic text manipulation: auto-correction, spelling-check and auto-capitalization
+SIM_PREFS_DIR="$HOME/Library/Developer/CoreSimulator/Devices/$UDID/data/Library/Preferences"
+mkdir -p "$SIM_PREFS_DIR"
+
+PLIST="$SIM_PREFS_DIR/com.apple.keyboard.preferences.plist"
+
+/usr/libexec/PlistBuddy -c "Add :KeyboardAutocorrection bool false" "$PLIST" 2>/dev/null || \
+/usr/libexec/PlistBuddy -c "Set :KeyboardAutocorrection bool false" "$PLIST"
+
+/usr/libexec/PlistBuddy -c "Add :KeyboardCheckSpelling bool false" "$PLIST" 2>/dev/null || \
+/usr/libexec/PlistBuddy -c "Set :KeyboardCheckSpelling bool false" "$PLIST"
+
+/usr/libexec/PlistBuddy -c "Add :KeyboardAutocapitalization bool false" "$PLIST" 2>/dev/null || \
+/usr/libexec/PlistBuddy -c "Set :KeyboardAutocapitalization bool false" "$PLIST"
+
 STATE=$(xcrun simctl list devices | grep "$UDID" | grep -oE '\(Booted\)|\(Shutdown\)' || true)
 if [ "$STATE" != "(Booted)" ]; then
   echo "Booting '$DEVICE_NAME' ($UDID)..."

.maestro/enrichedInput/screenshots/android/paragraph_styles_blocks.png

@@ -12,10 +12,43 @@ export async function pasteInto(locator: Locator): Promise<void> {
   await locator.page().keyboard.press('ControlOrMeta+V');
 }
 
+export async function copyWholeContent(locator: Locator): Promise<void> {
+  await locator.click();
+  await locator.page().waitForTimeout(100);
+  await locator.page().keyboard.press('ControlOrMeta+A');
+  await locator.page().keyboard.press('ControlOrMeta+C');
+}
+
+export async function pasteIntoWholeContent(locator: Locator): Promise<void> {
+  await locator.click();
+  await locator.page().waitForTimeout(100);
+  await locator.page().keyboard.press('ControlOrMeta+A');
+  await locator.page().keyboard.press('ControlOrMeta+V');
+}
+
 export async function copyAndPasteBetween(
   source: Locator,
   dest: Locator
 ): Promise<void> {
   await copySelectionFrom(source);
   await pasteInto(dest);
 }
+
+export async function pastePlainTextIntoEditor(
+  editorInnerLocator: Locator,
+  text: string
+): Promise<void> {
+  const pm = editorInnerLocator.locator('.ProseMirror');
+  await pm.click();
+  await pm.evaluate((el, t) => {
+    const dt = new DataTransfer();
+    dt.setData('text/plain', t);
+    el.dispatchEvent(
+      new ClipboardEvent('paste', {
+        clipboardData: dt,
+        bubbles: true,
+        cancelable: true,
+      })
+    );
+  }, text);
+}

.maestro/scripts/setup-android-emulator.sh

@@ -26,6 +26,7 @@ export default defineConfig({
     trace: 'on-first-retry',
     screenshot: 'only-on-failure',
     video: 'retain-on-failure',
+    permissions: ['clipboard-read', 'clipboard-write'],
   },
 
   webServer: {

.maestro/scripts/setup-ios-simulator.sh

@@ -6,6 +6,11 @@ import {
   gotoVisualRegression,
   setEditorHtml,
 } from '../helpers/visual-regression';
+import {
+  copyWholeContent,
+  pasteIntoWholeContent,
+  pastePlainTextIntoEditor,
+} from '../helpers/clipboard';
 
 test.setTimeout(90_000);
 
@@ -27,6 +32,8 @@ const sel = {
   onLinkDetectedPayload: '[data-testid="on-link-detected-payload"]',
   editorInner: '[data-testid="test-links-editor"] .eti-editor',
   editorScreenshot: '[data-testid="test-links-editor"]',
+  linkRegexMode: '[data-testid="test-links-link-regex-mode"]',
+  linkRegexPattern: '[data-testid="test-links-link-regex-pattern"]',
 } as const;
 
 async function gotoTestLinks(page: Page): Promise<void> {
@@ -352,3 +359,158 @@ test.describe('test-links onLinkDetected', () => {
       });
   });
 });
+
+test.describe('test-links autolink', () => {
+  async function resetEditorAndSetLinkRegexMode(
+    page: Page,
+    mode: 'default' | 'disabled' | 'custom'
+  ): Promise<void> {
+    await gotoTestLinks(page);
+    await page.locator(sel.linkRegexMode).selectOption(mode);
+    await setTestLinksEditorHtml(page, '<html><p></p></html>');
+  }
+
+  test('creates link while typing with default URL regex', async ({ page }) => {
+    await resetEditorAndSetLinkRegexMode(page, 'default');
+
+    const editor = page.locator(sel.editorInner);
+    await editor.click();
+    await expect(editor.locator('.ProseMirror')).toBeFocused();
+    await page.keyboard.type('Visit https://example.com');
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="https://example.com">https://example.com</a>');
+  });
+
+  test('creates link while typing with custom regex', async ({ page }) => {
+    await gotoTestLinks(page);
+    await page.locator(sel.linkRegexMode).selectOption('custom');
+    await page.fill(sel.linkRegexPattern, String.raw`issue-\d+`);
+    await setTestLinksEditorHtml(page, '<html><p></p></html>');
+
+    const editor = page.locator(sel.editorInner);
+    await editor.click();
+    await expect(editor.locator('.ProseMirror')).toBeFocused();
+    await page.keyboard.type('tick issue-123 done');
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="issue-123">issue-123</a>');
+  });
+
+  test('creates link when pasting plain URL with default regex', async ({
+    page,
+  }) => {
+    await resetEditorAndSetLinkRegexMode(page, 'default');
+
+    await pastePlainTextIntoEditor(
+      page.locator(sel.editorInner),
+      'https://example.com'
+    );
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="https://example.com">https://example.com</a>');
+  });
+
+  test('does not autolink when link regex is disabled', async ({ page }) => {
+    await resetEditorAndSetLinkRegexMode(page, 'disabled');
+
+    const editor = page.locator(sel.editorInner);
+    await editor.click();
+    await expect(editor.locator('.ProseMirror')).toBeFocused();
+    await page.keyboard.type('https://example.com');
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .not.toContain('<a href');
+  });
+});
+
+test.describe('test-links copy-paste', () => {
+  test.use({ permissions: ['clipboard-read', 'clipboard-write'] });
+
+  test('manual link (href ≠ text) survives copy-paste', async ({ page }) => {
+    await gotoTestLinks(page);
+    const editor = page.locator(sel.editorInner);
+
+    await setTestLinksEditorHtml(
+      page,
+      '<html><p><a href="https://example.com">Click here</a></p></html>'
+    );
+
+    await copyWholeContent(editor);
+    await setTestLinksEditorHtml(page, '<html><p></p></html>');
+    await pasteIntoWholeContent(editor);
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="https://example.com">Click here</a>');
+  });
+
+  test('autolink (href == text, matches regex) survives copy-paste', async ({
+    page,
+  }) => {
+    await gotoTestLinks(page);
+    await page.locator(sel.linkRegexMode).selectOption('default');
+    const editor = page.locator(sel.editorInner);
+
+    await setTestLinksEditorHtml(
+      page,
+      '<html><p><a href="https://example.com">https://example.com</a></p></html>'
+    );
+
+    await copyWholeContent(editor);
+    await setTestLinksEditorHtml(page, '<html><p></p></html>');
+    await pasteIntoWholeContent(editor);
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="https://example.com">https://example.com</a>');
+  });
+
+  test('manual link where href == text is not removed by autolink', async ({
+    page,
+  }) => {
+    await gotoTestLinks(page);
+    await page.locator(sel.linkRegexMode).selectOption('disabled');
+    const editor = page.locator(sel.editorInner);
+
+    await setTestLinksEditorHtml(
+      page,
+      '<html><p><a href="custom://link">custom://link</a></p></html>'
+    );
+
+    await copyWholeContent(editor);
+    await setTestLinksEditorHtml(page, '<html><p></p></html>');
+    await pasteIntoWholeContent(editor);
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="custom://link">custom://link</a>');
+  });
+});
+
+test.describe('test-links manual link editing', () => {
+  test('typing inside a manual link keeps the link covering the typed text', async ({
+    page,
+  }) => {
+    await gotoTestLinks(page);
+    await setTestLinksEditorHtml(
+      page,
+      '<html><p><a href="https://example.com">Hello</a></p></html>'
+    );
+
+    await page.fill(sel.selectionStart, '3');
+    await page.fill(sel.selectionEnd, '3');
+    await page.click(sel.applySelection);
+
+    await page.waitForTimeout(100);
+    await page.keyboard.type('TEST', { delay: 80 });
+
+    await expect
+      .poll(async () => getTestLinksSerializedHtml(page))
+      .toContain('<a href="https://example.com">HelTESTlo</a>');
+  });
+});