fix: test different checkbox drawing for tests

Author: kacperzolkiewski

.github/workflows/e2e.yml

@@ -125,7 +125,7 @@ jobs:
         with:
           name: e2e-ios-artifacts
           path: |
-            .maestro/screenshots/**/*_diff.png
+            .maestro/screenshots/ios/*_diff.png
 
   e2e-android:
     needs: [changes]
@@ -188,4 +188,4 @@ jobs:
         with:
           name: e2e-android-artifacts
           path: |
-            .maestro/screenshots/android/.maestro/screenshots/android/*_diff.png
+            .maestro/screenshots/android/*_diff.png

.maestro/screenshots/android/checkbox_toggle.png

@@ -5,8 +5,6 @@ import android.graphics.ColorFilter
 import android.graphics.Paint
 import android.graphics.Path
 import android.graphics.PixelFormat
-import android.graphics.PorterDuff
-import android.graphics.PorterDuffXfermode
 import android.graphics.drawable.Drawable
 
 class CheckboxDrawable(
@@ -15,42 +13,52 @@ class CheckboxDrawable(
   private var isChecked: Boolean,
 ) : Drawable() {
   private val paint = Paint(Paint.ANTI_ALIAS_FLAG)
-  private val path = Path()
+  private val strokeForCheckPaint = Paint(Paint.ANTI_ALIAS_FLAG)
+  private val rectPath = Path()
+  private val checkStrokePath = Path()
+  private val checkOutlinePath = Path()
 
   fun update(checked: Boolean) {
     this.isChecked = checked
     invalidateSelf()
   }
 
   override fun draw(canvas: Canvas) {
-    val saveCount = canvas.saveLayer(0f, 0f, size.toFloat(), size.toFloat(), null)
-
     paint.color = color
-    paint.style = Paint.Style.FILL
 
-    // Full square background with transparent checkmark
     if (isChecked) {
       val cornerRadius = size * 0.15f
-      canvas.drawRoundRect(0f, 0f, size.toFloat(), size.toFloat(), cornerRadius, cornerRadius, paint)
+      rectPath.reset()
+      rectPath.addRoundRect(
+        0f,
+        0f,
+        size.toFloat(),
+        size.toFloat(),
+        cornerRadius,
+        cornerRadius,
+        Path.Direction.CW,
+      )
+
+      checkStrokePath.reset()
+      checkStrokePath.moveTo(size * 0.25f, size * 0.5f)
+      checkStrokePath.lineTo(size * 0.45f, size * 0.7f)
+      checkStrokePath.lineTo(size * 0.75f, size * 0.3f)
 
-      paint.xfermode = PorterDuffXfermode(PorterDuff.Mode.XOR)
-      paint.strokeWidth = size * 0.15f
-      paint.style = Paint.Style.STROKE
-      paint.strokeCap = Paint.Cap.ROUND
-      paint.strokeJoin = Paint.Join.ROUND
+      strokeForCheckPaint.style = Paint.Style.STROKE
+      strokeForCheckPaint.strokeWidth = size * 0.15f
+      strokeForCheckPaint.strokeCap = Paint.Cap.ROUND
+      strokeForCheckPaint.strokeJoin = Paint.Join.ROUND
+      checkOutlinePath.reset()
+      strokeForCheckPaint.getFillPath(checkStrokePath, checkOutlinePath)
 
-      path.reset()
-      path.moveTo(size * 0.25f, size * 0.5f)
-      path.lineTo(size * 0.45f, size * 0.7f)
-      path.lineTo(size * 0.75f, size * 0.3f)
-      canvas.drawPath(path, paint)
+      // rectPath minus check outline = filled shape with transparent tick (API 19+).
+      rectPath.op(checkOutlinePath, Path.Op.DIFFERENCE)
 
-      paint.xfermode = null
-      canvas.restoreToCount(saveCount)
+      paint.style = Paint.Style.FILL
+      canvas.drawPath(rectPath, paint)
       return
     }
 
-    // Border only square for unchecked state
     paint.style = Paint.Style.STROKE
     paint.strokeWidth = size * 0.1f
     val margin = paint.strokeWidth / 2f
@@ -64,8 +72,6 @@ class CheckboxDrawable(
       cornerRadius,
       paint,
     )
-
-    canvas.restoreToCount(saveCount)
   }
 
   override fun setAlpha(alpha: Int) {