fix(android): removing inline styles#672
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Android span handling when removing conflicting inline styles, aiming to ensure inline styles are removed only within the requested [start, end] range while preserving the same style applied before and after that range (fix for #671).
Changes:
- Update Android inline-style removal to split affected spans and re-apply the preserved left/right portions outside the removal range.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
exploIF
approved these changes
Jul 6, 2026
exploIF
reviewed
Jul 6, 2026
exploIF
left a comment
exploIF
left a comment
Collaborator
There was a problem hiding this comment.
Please add regression tests
Collaborator
|
Some of the tests are failing locally, please verify that |
Collaborator
Author
Some tests failed on the first run, but after rerunning the failed test cases, they all passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #671
This PR fixes removing inline styles within a range while preserving the styles before and after the selected range.
Test Plan
Run reproduction steps from issue: #671
The issue should be resolved.
Screenshots / Videos
Before:
Screen.Recording.2026-07-03.at.10.33.54.mov
After:
Screen.Recording.2026-07-03.at.10.43.23.mov
Compatibility
Checklist