fix(iOS): removing chars during IME composition#674
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets an iOS IME composition edge case by avoiding custom backspace/paragraph handling during marked-text (IME composition) and by ensuring placeholder visibility stays in sync even when composition prevents the normal modification flow.
Changes:
- Skip
ParagraphAttributesUtilsmanual backspace intervention whileUITextView.markedTextRangeis active (IME composition). - Refactor placeholder show/hide logic into a dedicated helper and invoke it in the early-return path for marked text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ios/utils/ParagraphAttributesUtils.mm | Adds a marked-text guard to avoid custom backspace handling during IME composition. |
| ios/EnrichedTextInputView.mm | Extracts placeholder visibility logic into handlePlaceholderVisibility and calls it during marked-text early return. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
szydlovsky
approved these changes
Jul 6, 2026
Co-authored-by: Mikołaj Szydłowski <9szydlowski9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #673
Test Plan
Run reproduction steps from #673
the issue should be resolved.
Screenshots / Videos
Screen.Recording.2026-07-06.at.11.31.23.mov
Compatibility
Checklist