Skip to content

fix: ignore fontWeight '0' values #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szydlovsky merged 1 commit into from
Jun 16, 2025
+10 −1
Merged

fix: ignore fontWeight '0' values #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ios/config/EditorConfig.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,19 @@ - (void)setPrimaryFontFamily:(NSString *)newValue {
- (UIFont *)primaryFont {
if(_primaryFontNeedsRecreation) {
_primaryFontNeedsRecreation = NO;

NSString *newFontWeight = [self primaryFontWeight];
// fix RCTFontWeight conversion warnings:
// sometimes changing font family comes with weight '0' if not specified
// RCTConvert doesn't recognize this value so we just nullify it and it gets a default value
if([newFontWeight isEqualToString:@"0"]) {
newFontWeight = nullptr;
}

_primaryFont = [RCTFont updateFont:nullptr
withFamily:[self primaryFontFamily]
size:[self primaryFontSize]
weight:[self primaryFontWeight]
weight:newFontWeight
style:nullptr
variant:nullptr
scaleMultiplier: 1];
Expand Down
Loading