refactor: changes suggested by claude

Author: NorbertKlockiewicz

apps/computer-vision/app/vision_camera/index.tsx

@@ -221,7 +221,7 @@ export default function VisionCameraScreen() {
         outputs={frameOutput ? [frameOutput] : []}
         isActive={isFocused}
         format={format}
-        orientationSource="device"
+        orientationSource="interface"
       />
 
       {/* Layout sentinel — measures the full-screen area for bbox/canvas sizing */}

apps/computer-vision/components/vision_camera/tasks/ClassificationTask.tsx

@@ -75,7 +75,7 @@ export default function ClassificationTask({
             scheduleOnRN(updateClass, { label: bestLabel, score: bestScore });
           }
         } catch {
-          // ignore
+          // Frame may be disposed before processing completes — transient, safe to ignore.
         } finally {
           frame.dispose();
         }

apps/computer-vision/components/vision_camera/tasks/OCRTask.tsx

@@ -72,7 +72,7 @@ export default function OCRTask({
             });
           }
         } catch {
-          // ignore
+          // Frame may be disposed before processing completes — transient, safe to ignore.
         } finally {
           frame.dispose();
         }

apps/computer-vision/components/vision_camera/tasks/ObjectDetectionTask.tsx

@@ -93,7 +93,7 @@ export default function ObjectDetectionTask({
             });
           }
         } catch {
-          // ignore
+          // Frame may be disposed before processing completes — transient, safe to ignore.
         } finally {
           frame.dispose();
         }

apps/computer-vision/components/vision_camera/tasks/SegmentationTask.tsx

@@ -185,7 +185,7 @@ export default function SegmentationTask({
             if (img) scheduleOnRN(updateMask, img);
           }
         } catch {
-          // ignore
+          // Frame may be disposed before processing completes — transient, safe to ignore.
         } finally {
           frame.dispose();
         }

apps/computer-vision/components/vision_camera/tasks/StyleTransferTask.tsx

@@ -121,7 +121,7 @@ export default function StyleTransferTask({
             if (img) scheduleOnRN(updateImage, img);
           }
         } catch {
-          // ignore
+          // Frame may be disposed before processing completes — transient, safe to ignore.
         } finally {
           frame.dispose();
         }

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.cpp

@@ -4,6 +4,10 @@ namespace rnexecutorch::utils {
 
 cv::Mat rotateFrameForModel(const cv::Mat &mat,
                             const FrameOrientation &orient) {
+  if (!orient.isMirrored && orient.orientation == "up") {
+    return mat.clone();
+  }
+
   cv::Mat result = mat.clone();
 
   if (orient.isMirrored) {
@@ -28,23 +32,23 @@ void inverseRotateBbox(float &x1, float &y1, float &x2, float &y2,
   const float h = static_cast<float>(rH);
 
   if (orient.orientation == "up") {
-    // CW: nx = h - y, ny = x
+    // landscape-left → portrait: nx = h - y, ny = x
     float nx1 = h - y2, ny1 = x1;
     float nx2 = h - y1, ny2 = x2;
     x1 = nx1;
     y1 = ny1;
     x2 = nx2;
     y2 = ny2;
   } else if (orient.orientation == "right") {
-    // 180°: nx = w - x, ny = h - y
+    // upside-down portrait → portrait: nx = w - x, ny = h - y
     float nx1 = w - x2, ny1 = h - y2;
     float nx2 = w - x1, ny2 = h - y1;
     x1 = nx1;
     y1 = ny1;
     x2 = nx2;
     y2 = ny2;
   } else if (orient.orientation == "down") {
-    // CCW: nx = y, ny = w - x
+    // landscape-right → portrait: nx = y, ny = w - x
     float nx1 = y1, ny1 = w - x2;
     float nx2 = y2, ny2 = w - x1;
     x1 = nx1;

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.h

@@ -63,15 +63,15 @@ void inverseRotatePoints(std::array<P, 4> &points,
     float y = p.y;
 
     if (orient.orientation == "up") {
-      // CW: nx = h-y, ny = x
+      // landscape-left → portrait: nx = h-y, ny = x
       p.x = h - y;
       p.y = x;
     } else if (orient.orientation == "right") {
-      // 180°: nx = w-x, ny = h-y
+      // upside-down portrait → portrait: nx = w-x, ny = h-y
       p.x = w - x;
       p.y = h - y;
     } else if (orient.orientation == "down") {
-      // CCW: nx = y, ny = w-x
+      // landscape-right → portrait: nx = y, ny = w-x
       p.x = y;
       p.y = w - x;
     }

packages/react-native-executorch/src/modules/computer_vision/VisionModule.ts

@@ -52,7 +52,7 @@ export abstract class VisionModule<TOutput> extends BaseModule {
    *   onFrame(frame) {
    *     'worklet';
    *     if (!runOnFrame) return;
-   *     const result = runOnFrame(frame);
+   *     const result = runOnFrame(frame, isMirrored);
    *     frame.dispose();
    *   }
    * });