chore: type fix, review changes

Author: chmjkb

docs/docs/04-typescript-api/02-computer-vision/PoseEstimationModule.md

@@ -96,7 +96,7 @@ detections[0].THUMB_TIP; // { x, y }
 
 The `.pte` binary must expose a `forward` method (or per-input-size methods such as `forward_384`, `forward_512`, `forward_640` for multi-resolution models) with the following interface:
 
-**Input:** one `float32` tensor of shape `[1, 3, H, W]` — a single RGB image, values in `[0, 1]` after optional per-channel normalization `(pixel − mean) / std`. H and W are read from the model's declared input shape at load time. The mean and std vectors are supplied via `preprocessorConfig.normMean` and `preprocessorConfig.normStd` on the [`PoseEstimationConfig`](../../06-api-reference/interfaces/PoseEstimationConfig.md) you pass to `fromCustomModel`; if omitted, the runtime feeds the resized image without normalization.
+**Input:** one `float32` tensor of shape `[1, 3, H, W]` — a single RGB image, values in `[0, 1]` after optional per-channel normalization `(pixel − mean) / std`. H and W are read from the model's declared input shape at load time. The mean and std vectors are supplied via `preprocessorConfig.normMean` and `preprocessorConfig.normStd` on the [`PoseEstimationConfig`](../../06-api-reference/type-aliases/PoseEstimationConfig.md) you pass to `fromCustomModel`; if omitted, the runtime feeds the resized image without normalization.
 
 **Outputs:** exactly three `float32` tensors, in this order:
 

packages/react-native-executorch/common/rnexecutorch/tests/README.md

@@ -69,5 +69,8 @@ To add new test you need to:
         LIBS opencv_deps
     )
     ```
-* Lastly, add the test executable name to the run_tests script along with all the needed URL and assets.
+* In `run_tests.sh`:
+  * Add the test executable name to `TEST_EXECUTABLES`.
+  * Add any models/files the test downloads at runtime to `MODELS` (filename + URL), **and** register every downloaded file the test loads in the `models_for_test()` case statement. The runner pushes only the files listed there from `$MODELS_DIR` to the device for that test, runs it, and removes them afterwards — anything missing won't be on the device when the test runs. Tests with no model dependencies don't need an entry.
+  * Repo-bundled fixtures (small images, audio, etc.) go in `TEST_ASSETS` instead. Those are pushed once up front and stay on the device; do not list them in `models_for_test()`.
 

packages/react-native-executorch/common/rnexecutorch/tests/run_tests.sh

@@ -209,6 +209,7 @@ models_for_test() {
     LLMTests) echo "smolLm2_135M_8da4w.pte smollm_tokenizer.json lfm2_5_vl_quantized_xnnpack_v2.pte lfm2_vl_tokenizer.json lfm2_vl_tokenizer_config.json test_image.jpg" ;;
     TextToImageTests) echo "t2i_tokenizer.json t2i_encoder.pte t2i_unet.pte t2i_decoder.pte" ;;
     InstanceSegmentationTests) echo "yolo26n-seg.pte segmentation_image.jpg" ;;
+    PoseEstimationTests) echo "yolo26n-pose.pte" ;;
     SemanticSegmentationTests) echo "deeplabV3_xnnpack_fp32.pte test_image.jpg" ;;
     OCRTests | VerticalOCRTests) echo "xnnpack_craft_quantized.pte xnnpack_crnn_english.pte" ;;
     *) echo "" ;;

packages/react-native-executorch/src/constants/poseEstimation.ts

@@ -3,22 +3,22 @@
  * Use for type-safe keypoint access: `keypoints[CocoKeypoint.NOSE]`
  * @category Types
  */
-export const CocoKeypoint = {
-  NOSE: 0,
-  LEFT_EYE: 1,
-  RIGHT_EYE: 2,
-  LEFT_EAR: 3,
-  RIGHT_EAR: 4,
-  LEFT_SHOULDER: 5,
-  RIGHT_SHOULDER: 6,
-  LEFT_ELBOW: 7,
-  RIGHT_ELBOW: 8,
-  LEFT_WRIST: 9,
-  RIGHT_WRIST: 10,
-  LEFT_HIP: 11,
-  RIGHT_HIP: 12,
-  LEFT_KNEE: 13,
-  RIGHT_KNEE: 14,
-  LEFT_ANKLE: 15,
-  RIGHT_ANKLE: 16,
-} as const;
+export enum CocoKeypoint {
+  NOSE = 0,
+  LEFT_EYE = 1,
+  RIGHT_EYE = 2,
+  LEFT_EAR = 3,
+  RIGHT_EAR = 4,
+  LEFT_SHOULDER = 5,
+  RIGHT_SHOULDER = 6,
+  LEFT_ELBOW = 7,
+  RIGHT_ELBOW = 8,
+  LEFT_WRIST = 9,
+  RIGHT_WRIST = 10,
+  LEFT_HIP = 11,
+  RIGHT_HIP = 12,
+  LEFT_KNEE = 13,
+  RIGHT_KNEE = 14,
+  LEFT_ANKLE = 15,
+  RIGHT_ANKLE = 16,
+}

packages/react-native-executorch/src/modules/computer_vision/PoseEstimationModule.ts

@@ -1,4 +1,9 @@
-import { Frame, PixelData, ResourceSource } from '../../types/common';
+import {
+  Frame,
+  LabelEnum,
+  PixelData,
+  ResourceSource,
+} from '../../types/common';
 import {
   Keypoint,
   PersonKeypoints,
@@ -7,7 +12,6 @@ import {
   PoseEstimationModelSources,
   PoseEstimationModelName,
   PoseEstimationConfig,
-  KeypointEnum,
 } from '../../types/poseEstimation';
 import { RnExecutorchErrorCode } from '../../errors/ErrorCodes';
 import { RnExecutorchError } from '../../errors/errorUtils';
@@ -29,13 +33,13 @@ const ModelConfigs = {
   'yolo26n-pose': YOLO_POSE_CONFIG,
 } as const satisfies Record<
   PoseEstimationModelName,
-  PoseEstimationConfig<KeypointEnum>
+  PoseEstimationConfig<LabelEnum>
 >;
 
 type ModelConfigsType = typeof ModelConfigs;
 
 /**
- * Resolves the {@link KeypointEnum} for a given built-in pose estimation model name.
+ * Resolves the {@link LabelEnum} for a given built-in pose estimation model name.
  * @typeParam M - A built-in model name from {@link PoseEstimationModelName}.
  * @category Types
  */
@@ -45,10 +49,10 @@ export type PoseEstimationKeypoints<M extends PoseEstimationModelName> =
 type ModelNameOf<C extends PoseEstimationModelSources> = C['modelName'];
 
 /** @internal */
-type ResolveKeypoints<T extends PoseEstimationModelName | KeypointEnum> =
+type ResolveKeypoints<T extends PoseEstimationModelName | LabelEnum> =
   ResolveConfigOrType<T, ModelConfigsType, 'keypointMap'>;
 
-function mapPersonKeypoints<K extends KeypointEnum>(
+function mapPersonKeypoints<K extends LabelEnum>(
   raw: Keypoint[][],
   entries: [string, number][],
   maxIndex: number
@@ -71,26 +75,33 @@ function mapPersonKeypoints<K extends KeypointEnum>(
 /**
  * Pose estimation module for detecting human body keypoints.
  * @typeParam T - Either a built-in model name (e.g. `'yolo26n-pose'`)
- *   or a custom {@link KeypointEnum} keypoint map.
+ *   or a custom {@link LabelEnum} keypoint map.
  * @category Typescript API
  */
 export class PoseEstimationModule<
-  T extends PoseEstimationModelName | KeypointEnum,
+  T extends PoseEstimationModelName | LabelEnum,
 > extends VisionModule<PoseDetections<ResolveKeypoints<T>>> {
   private readonly keypointMap: ResolveKeypoints<T>;
-  private readonly modelConfig: PoseEstimationConfig<KeypointEnum>;
+  private readonly modelConfig: PoseEstimationConfig<LabelEnum>;
+  // Numeric TS enums double-list
+  // their keys at runtime (value → name); we keep only the (name, index) pairs
+  private readonly keypointEntries: [string, number][];
   private readonly maxKeypointIndex: number;
 
   private constructor(
     keypointMap: ResolveKeypoints<T>,
-    modelConfig: PoseEstimationConfig<KeypointEnum>,
+    modelConfig: PoseEstimationConfig<LabelEnum>,
     nativeModule: unknown
   ) {
     super();
     this.keypointMap = keypointMap;
     this.modelConfig = modelConfig;
     this.nativeModule = nativeModule;
-    this.maxKeypointIndex = Math.max(...Object.values(keypointMap));
+    this.keypointEntries = [];
+    for (const [name, value] of Object.entries(keypointMap)) {
+      if (typeof value === 'number') this.keypointEntries.push([name, value]);
+    }
+    this.maxKeypointIndex = Math.max(...this.keypointEntries.map(([, v]) => v));
   }
 
   /**
@@ -106,7 +117,7 @@ export class PoseEstimationModule<
     const { modelSource } = namedSources;
     const modelConfig = ModelConfigs[
       namedSources.modelName
-    ] as PoseEstimationConfig<KeypointEnum>;
+    ] as PoseEstimationConfig<LabelEnum>;
     const { keypointMap, preprocessorConfig } = modelConfig;
     const normMean = preprocessorConfig?.normMean ?? [];
     const normStd = preprocessorConfig?.normStd ?? [];
@@ -133,7 +144,7 @@ export class PoseEstimationModule<
    * @param onDownloadProgress - Optional callback to monitor download progress (0-1).
    * @returns A Promise resolving to a `PoseEstimationModule` instance typed to the provided keypoint map.
    */
-  static async fromCustomModel<K extends KeypointEnum>(
+  static async fromCustomModel<K extends LabelEnum>(
     modelSource: ResourceSource,
     config: PoseEstimationConfig<K>,
     onDownloadProgress: (progress: number) => void = () => {}
@@ -195,7 +206,7 @@ export class PoseEstimationModule<
       this.modelConfig.defaultKeypointThreshold ?? 0.5;
     const defaultInputSize = this.modelConfig.defaultInputSize;
     const availableInputSizes = this.modelConfig.availableInputSizes;
-    const keypointEntries = Object.entries(this.keypointMap);
+    const keypointEntries = this.keypointEntries;
     const maxKeypointIndex = this.maxKeypointIndex;
     return (
       frame: Frame,
@@ -308,10 +319,9 @@ export class PoseEstimationModule<
             methodName
           );
 
-    const entries = Object.entries(this.keypointMap);
     return mapPersonKeypoints<ResolveKeypoints<T>>(
       raw,
-      entries,
+      this.keypointEntries,
       this.maxKeypointIndex
     );
   }

packages/react-native-executorch/src/types/poseEstimation.ts

@@ -1,16 +1,9 @@
-import { Frame, PixelData, ResourceSource } from './common';
+import { Frame, LabelEnum, PixelData, ResourceSource } from './common';
 import { CocoKeypoint } from '../constants/poseEstimation';
 import { RnExecutorchError } from '../errors/errorUtils';
 
 export { CocoKeypoint };
 
-/**
- * A keypoint enum maps keypoint names to their indices.
- * Similar to LabelEnum but specifically for pose keypoints.
- * @category Types
- */
-export type KeypointEnum = Readonly<Record<string, number>>;
-
 /**
  * A single keypoint with x, y coordinates
  * @category Types
@@ -22,30 +15,30 @@ export interface Keypoint {
 
 /**
  * Keypoints for a single detected person, keyed by name from the keypoint map.
- * @typeParam K - The {@link KeypointEnum} for this model.
+ * @typeParam K - The {@link LabelEnum} for this model.
  * @category Types
  * @example
  * ```ts
  * person.NOSE; // { x, y }
  * ```
  */
-export type PersonKeypoints<K extends KeypointEnum = typeof CocoKeypoint> = {
+export type PersonKeypoints<K extends LabelEnum = typeof CocoKeypoint> = {
   readonly [Name in keyof K]: Keypoint;
 };
 
 /**
  * Pose estimation result containing all detected people.
  * @category Types
  */
-export type PoseDetections<K extends KeypointEnum = typeof CocoKeypoint> =
+export type PoseDetections<K extends LabelEnum = typeof CocoKeypoint> =
   PersonKeypoints<K>[];
 
 /**
  * Configuration for pose estimation model behavior.
  * @category Types
  * @typeParam K - The keypoint enum type for this model.
  */
-export type PoseEstimationConfig<K extends KeypointEnum> = {
+export type PoseEstimationConfig<K extends LabelEnum> = {
   keypointMap: K;
   preprocessorConfig?: {
     normMean?: readonly [number, number, number];
@@ -112,10 +105,10 @@ export interface PoseEstimationOptions {
 
 /**
  * Return type of usePoseEstimation hook.
- * @typeParam K - The {@link KeypointEnum} representing the model's keypoint schema.
+ * @typeParam K - The {@link LabelEnum} representing the model's keypoint schema.
  * @category Types
  */
-export interface PoseEstimationType<K extends KeypointEnum> {
+export interface PoseEstimationType<K extends LabelEnum> {
   /**
    * Contains the error object if the model failed to load or encountered a runtime error.
    */