Skip to content

Commit 3ea1a50

Browse files
fix: replace magic number 4 with channels field in PixelDataResult
1 parent 836c7a2 commit 3ea1a50

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@ getJsiValue(const models::style_transfer::PixelDataResult &result,
575575
auto sizesArray = jsi::Array(runtime, 3);
576576
sizesArray.setValueAtIndex(runtime, 0, jsi::Value(result.height));
577577
sizesArray.setValueAtIndex(runtime, 1, jsi::Value(result.width));
578-
sizesArray.setValueAtIndex(runtime, 2, jsi::Value(4));
578+
sizesArray.setValueAtIndex(runtime, 2, jsi::Value(result.channels));
579579
obj.setProperty(runtime, "sizes", sizesArray);
580580

581581
obj.setProperty(runtime, "scalarType",

packages/react-native-executorch/common/rnexecutorch/models/style_transfer/StyleTransfer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ PixelDataResult toPixelDataResult(const cv::Mat &bgrMat) {
6161
cv::cvtColor(bgrMat, rgba, cv::COLOR_BGR2RGBA);
6262
std::size_t dataSize = static_cast<std::size_t>(size.width) * size.height * 4;
6363
auto pixelBuffer = std::make_shared<OwningArrayBuffer>(rgba.data, dataSize);
64-
return PixelDataResult{pixelBuffer, size.width, size.height};
64+
return PixelDataResult{pixelBuffer, size.width, size.height, rgba.channels()};
6565
}
6666

6767
StyleTransferResult StyleTransfer::generateFromString(std::string imageSource,

packages/react-native-executorch/common/rnexecutorch/models/style_transfer/Types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ struct PixelDataResult {
1111
std::shared_ptr<OwningArrayBuffer> dataPtr;
1212
int width;
1313
int height;
14+
int channels;
1415
};
1516

1617
using StyleTransferResult = std::variant<PixelDataResult, std::string>;

0 commit comments

Comments
 (0)