Skip to content

Commit 40d27fb

Browse files
committed
fix: fixes after rebase
1 parent d31a5b4 commit 40d27fb

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ getJsiValue(const std::unordered_map<std::string_view, float> &map,
9191
mapObj.setProperty(runtime, k.data(), v);
9292
}
9393
return mapObj;
94-
94+
}
95+
9596
inline jsi::Value getJsiValue(const std::vector<Detection> &detections,
9697
jsi::Runtime &runtime) {
9798
jsi::Array array(runtime, detections.size());

packages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ std::vector<Detection> ObjectDetection::forward(std::string imageSource,
7777
double detectionThreshold) {
7878
auto [tensor, originalSize] = preprocess(imageSource);
7979

80-
auto forwardResult = module->forward(tensor);
80+
auto forwardResult = forwardET(tensor);
8181
if (!forwardResult.ok()) {
8282
throw std::runtime_error(
8383
"Failed to forward, error: " +

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@ import { ResourceFetcher } from '../../utils/ResourceFetcher';
22
import { ResourceSource } from '../../types/common';
33
import { Detection } from '../../types/objectDetection';
44
import { ETError, getError } from '../../Error';
5+
import { BaseNonStaticModule } from '../BaseNonStaticModule';
56

6-
export class ObjectDetectionModule {
7-
nativeModule: any = null;
8-
7+
export class ObjectDetectionModule extends BaseNonStaticModule {
98
async load(
109
modelSource: ResourceSource,
1110
onDownloadProgressCallback: (_: number) => void = () => {}

0 commit comments

Comments
 (0)