Skip to content

Commit 45a390b

Browse files
committed
Increase log messages and add ellipsis
1 parent 5d8a5a0 commit 45a390b

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

common/Log.h

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@
1212

1313
namespace rnexecutorch {
1414

15-
enum LOG_LEVEL { INFO_LVL, ERROR_LVL, DEBUG_LVL };
15+
enum class LOG_LEVEL { INFO, ERROR, DEBUG };
1616

1717
#ifdef __ANDROID__
1818
android_LogPriority androidLogLevel(LOG_LEVEL logLevel) {
1919
switch (logLevel) {
20-
case LOG_LEVEL::INFO_LVL:
20+
case LOG_LEVEL::INFO:
2121
default:
2222
return ANDROID_LOG_INFO;
23-
case LOG_LEVEL::ERROR_LVL:
23+
case LOG_LEVEL::ERROR:
2424
return ANDROID_LOG_ERROR;
25-
case LOG_LEVEL::DEBUG_LVL:
25+
case LOG_LEVEL::DEBUG:
2626
return ANDROID_LOG_DEBUG;
2727
}
2828
}
@@ -34,12 +34,13 @@ void log(LOG_LEVEL logLevel, const char *fmt, ...) {
3434
va_start(args, fmt);
3535

3636
// Maximum length of a log message.
37-
static constexpr size_t kMaxLogMessageLength = 256;
37+
static constexpr size_t kMaxLogMessageLength = 1024;
3838
char buf[kMaxLogMessageLength];
3939
size_t len = vsnprintf(buf, kMaxLogMessageLength, fmt, args);
4040
if (len >= kMaxLogMessageLength - 1) {
41-
buf[kMaxLogMessageLength - 2] = '$';
42-
len = kMaxLogMessageLength - 1;
41+
for (std::size_t i = 0; i < 3; ++i)
42+
buf[kMaxLogMessageLength - 2 - i] = '.';
43+
len = kMaxLogMessageLength - 3;
4344
}
4445
buf[kMaxLogMessageLength - 1] = 0;
4546

@@ -51,14 +52,14 @@ void log(LOG_LEVEL logLevel, const char *fmt, ...) {
5152
#ifdef __APPLE__
5253

5354
switch (logLevel) {
54-
case LOG_LEVEL::INFO_LVL:
55+
case LOG_LEVEL::INFO:
5556
default:
5657
os_log_info(OS_LOG_DEFAULT, "%s", buf);
5758
break;
58-
case LOG_LEVEL::ERROR_LVL:
59+
case LOG_LEVEL::ERROR:
5960
os_log_error(OS_LOG_DEFAULT, "%s", buf);
6061
break;
61-
case LOG_LEVEL::DEBUG_LVL:
62+
case LOG_LEVEL::DEBUG:
6263
os_log_debug(OS_LOG_DEFAULT, "%s", buf);
6364
break;
6465
}

0 commit comments

Comments
 (0)