refactor: remove unused code

Author: NorbertKlockiewicz

apps/computer-vision/components/vision_camera/tasks/OCRTask.tsx

@@ -6,7 +6,7 @@ import { OCR_ENGLISH, OCRDetection, useOCR } from 'react-native-executorch';
 import Svg, { Polygon, Text as SvgText } from 'react-native-svg';
 import { TaskProps } from './types';
 
-type Props = TaskProps & { activeModel: string };
+type Props = Omit<TaskProps, 'activeModel'>;
 
 export default function OCRTask({
   canvasSize,

packages/react-native-executorch/common/rnexecutorch/models/VisionModel.h

@@ -148,8 +148,8 @@ class VisionModel : public BaseModel {
   /**
    * @brief Read orientation metadata from JSI frameData object.
    *
-   * Reads orientation, isMirrored, frameWidth, frameHeight.
-   * Falls back to "up"/false/0/0 if fields are absent (e.g. when
+   * Reads orientation and isMirrored.
+   * Falls back to "up"/false if fields are absent (e.g. when
    * enablePhysicalBufferRotation is used — transform will then be a no-op).
    */
   utils::FrameOrientation extractFrameOrientation(

packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt

@@ -165,12 +165,6 @@ add_rn_test(FrameProcessorTests unit/FrameProcessorTest.cpp
     LIBS opencv_deps android
 )
 
-add_rn_test(FrameTransformTests unit/FrameTransformTest.cpp
-    SOURCES
-        ${RNEXECUTORCH_DIR}/utils/FrameTransform.cpp
-    LIBS opencv_deps
-)
-
 add_rn_test(BaseModelTests integration/BaseModelTest.cpp)
 
 add_rn_test(VisionModelTests integration/VisionModelTest.cpp

packages/react-native-executorch/common/rnexecutorch/tests/unit/FrameTransformTest.cpp

@@ -49,21 +49,7 @@ FrameOrientation readFrameOrientation(jsi::Runtime &runtime,
       isMirrored = val.getBool();
   }
 
-  int frameWidth = 0;
-  if (obj.hasProperty(runtime, "frameWidth")) {
-    auto val = obj.getProperty(runtime, "frameWidth");
-    if (val.isNumber())
-      frameWidth = static_cast<int>(val.asNumber());
-  }
-
-  int frameHeight = 0;
-  if (obj.hasProperty(runtime, "frameHeight")) {
-    auto val = obj.getProperty(runtime, "frameHeight");
-    if (val.isNumber())
-      frameHeight = static_cast<int>(val.asNumber());
-  }
-
-  return {orientation, isMirrored, frameWidth, frameHeight};
+  return {orientation, isMirrored};
 }
 
 cv::Mat pixelsToMat(const JSTensorViewIn &pixelData) {

packages/react-native-executorch/common/rnexecutorch/utils/FrameProcessor.cpp

@@ -31,8 +31,8 @@ cv::Mat frameToMat(jsi::Runtime &runtime, const jsi::Value &frameData);
 /**
  * @brief Read orientation metadata from a VisionCamera frameData JSI object.
  *
- * Reads orientation, isMirrored, frameWidth, frameHeight from the frameData
- * object. Falls back to "up"/false/0/0 if fields are absent (e.g. when
+ * Reads orientation and isMirrored from the frameData object.
+ * Falls back to "up"/false if fields are absent (e.g. when
  * enablePhysicalBufferRotation is used — transform will be a no-op).
  */
 FrameOrientation readFrameOrientation(jsi::Runtime &runtime,

packages/react-native-executorch/common/rnexecutorch/utils/FrameProcessor.h

@@ -1,46 +1,7 @@
 #include "FrameTransform.h"
-#include <cassert>
 
 namespace rnexecutorch::utils {
 
-void transformBbox(float &x1, float &y1, float &x2, float &y2,
-                   const FrameOrientation &orient) {
-  const float w = static_cast<float>(orient.frameWidth);
-  const float h = static_cast<float>(orient.frameHeight);
-
-  // Flip horizontally first
-  if (orient.isMirrored) {
-    float nx1 = w - x2;
-    float nx2 = w - x1;
-    x1 = nx1;
-    x2 = nx2;
-  }
-
-  // Sensor native = landscape-left — apply CW rotation for all orientations.
-  {
-    float nx1 = h - y2, ny1 = x1;
-    float nx2 = h - y1, ny2 = x2;
-    x1 = nx1;
-    y1 = ny1;
-    x2 = nx2;
-    y2 = ny2;
-  }
-}
-
-cv::Mat transformMat(const cv::Mat &mat, const FrameOrientation &orient) {
-  cv::Mat result = mat.clone();
-
-  // Flip first
-  if (orient.isMirrored) {
-    cv::flip(result, result, 1);
-  }
-
-  // Sensor native = landscape-left — apply CW rotation.
-  cv::rotate(result, result, cv::ROTATE_90_CLOCKWISE);
-
-  return result;
-}
-
 cv::Mat rotateFrameForModel(const cv::Mat &mat,
                             const FrameOrientation &orient) {
   cv::Mat result = mat.clone();

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.cpp

@@ -12,32 +12,8 @@ namespace rnexecutorch::utils {
 struct FrameOrientation {
   std::string orientation; // "up"|"right"|"left"|"down"
   bool isMirrored;
-  int frameWidth;  // raw frame width (sensor native, before any rotation)
-  int frameHeight; // raw frame height (sensor native, before any rotation)
 };
 
-/**
- * @brief Transform a bounding box from raw frame pixel space to screen space.
- *
- * Maps coordinates from raw frame pixel space to screen space.
- * orientation describes how the buffer is rotated relative to screen,
- * so we apply that same rotation (not its inverse) to map buffer points
- * into screen space. Applies flip (if isMirrored) first, then rotation.
- * Coordinates are absolute pixels in the raw frame (not normalized [0,1]).
- * x1/y1 = top-left corner, x2/y2 = bottom-right corner.
- * After transform, x1<=x2 and y1<=y2 are guaranteed.
- */
-void transformBbox(float &x1, float &y1, float &x2, float &y2,
-                   const FrameOrientation &orient);
-
-/**
- * @brief Rotate/flip a cv::Mat from raw frame space to screen space.
- *
- * Returns a new mat (does not modify input).
- * For right/left orientations, output rows/cols are swapped vs input.
- */
-cv::Mat transformMat(const cv::Mat &mat, const FrameOrientation &orient);
-
 /**
  * @brief Rotate/flip a cv::Mat so the model sees an upright image.
  *
@@ -69,33 +45,6 @@ void inverseRotateBbox(float &x1, float &y1, float &x2, float &y2,
  */
 cv::Mat inverseRotateMat(const cv::Mat &mat, const FrameOrientation &orient);
 
-/**
- * @brief Transform 4-point bbox from raw frame pixel space to screen space.
- *
- * Templated on point type — requires P to have float x and y members.
- * Applies same flip-then-rotate logic as transformBbox, per point.
- * Template implementation in header (required for templates).
- */
-template <typename P>
-void transformPoints(std::array<P, 4> &points, const FrameOrientation &orient) {
-  const float w = static_cast<float>(orient.frameWidth);
-  const float h = static_cast<float>(orient.frameHeight);
-
-  for (auto &p : points) {
-    float x = p.x;
-    float y = p.y;
-
-    // Flip first
-    if (orient.isMirrored) {
-      x = w - x;
-    }
-
-    // Sensor native = landscape-left — apply CW rotation for all orientations.
-    p.x = h - y;
-    p.y = x;
-  }
-}
-
 /**
  * @brief Map 4-point bbox from rotated-frame space back to screen space.
  *