Skip to content

Commit 648d96b

Browse files
msluszniakclaude
andauthored
chore: clean up root peer deps and drop ignored resolutions (#1083)
## Summary Silences the peer-dep and `resolutions` warnings that show up on every root `yarn install`: - Remove `expo-router` from root `devDependencies` — it's only consumed by the Expo apps (`apps/llm`, `apps/computer-vision`, `apps/text-embeddings`), each of which already declares it. At the root it pulled in a chain of unmet peer warnings (`expo`, `expo-constants`, `expo-linking`, `react`, `react-native`, `react-native-safe-area-context`, `react-native-screens`). - Add `@babel/eslint-parser` and its own peer `@babel/core` to root `devDependencies` to satisfy `eslint-plugin-ft-flow`'s peer requirement. - Delete the `resolutions` field inside `packages/react-native-executorch/package.json`. Yarn 4 only honors `resolutions` at the workspace root, so it was being ignored (`YN0057`), and it pinned `@types/react` to `^18.2.44` while every workspace already uses `~19.x` — dead config. Before: ``` ➤ YN0057: react-native-executorch: Resolutions field will be ignored ➤ YN0002: ...doesn't provide @babel/eslint-parser (requested by eslint-plugin-ft-flow) ➤ YN0002: ...doesn't provide expo (requested by expo-router) ➤ YN0002: ...doesn't provide expo-constants (requested by expo-router) ➤ YN0002: ...doesn't provide expo-linking (requested by expo-router) ➤ YN0002: ...doesn't provide react (requested by expo-router) ➤ YN0002: ...doesn't provide react-native (requested by expo-router) ➤ YN0002: ...doesn't provide react-native-safe-area-context (requested by expo-router) ➤ YN0002: ...doesn't provide react-native-screens (requested by expo-router) ➤ YN0086: Some peer dependencies are incorrectly met ``` After: `yarn` completes without any warning lines. ## Test plan - [ ] `yarn` at repo root completes without `YN0002` / `YN0057` / `YN0086` warnings - [ ] `yarn lint` passes - [ ] `yarn typecheck` passes - [ ] Expo apps (`apps/llm`, `apps/computer-vision`, `apps/text-embeddings`) still resolve `expo-router` from their own `dependencies` Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 93a4703 commit 648d96b

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
},
1717
"private": true,
1818
"devDependencies": {
19+
"@babel/core": "^7.25.1",
20+
"@babel/eslint-parser": "^7.25.1",
1921
"@cspell/eslint-plugin": "^8.19.0",
2022
"@evilmartians/lefthook": "^2.1.1",
2123
"@react-native/eslint-config": "^0.79.0",
@@ -25,7 +27,6 @@
2527
"eslint-plugin-jsdoc": "^62.7.1",
2628
"eslint-plugin-markdown": "^5.1.0",
2729
"eslint-plugin-prettier": "^5.0.1",
28-
"expo-router": "~6.0.17",
2930
"prettier": "^3.3.3",
3031
"prettier-plugin-jsdoc": "^1.3.0",
3132
"typescript": "~5.9.2"

packages/react-native-executorch/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,6 @@
8181
"react-native-builder-bob": "^0.40.12",
8282
"typescript": "~5.9.2"
8383
},
84-
"resolutions": {
85-
"@types/react": "^18.2.44"
86-
},
8784
"workspaces": [
8885
"example"
8986
],

yarn.lock

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ __metadata:
6060
languageName: node
6161
linkType: hard
6262

63-
"@babel/core@npm:^7.11.6, @babel/core@npm:^7.12.3, @babel/core@npm:^7.20.0, @babel/core@npm:^7.21.3, @babel/core@npm:^7.23.9, @babel/core@npm:^7.25.2, @babel/core@npm:^7.27.4, @babel/core@npm:^7.29.0":
63+
"@babel/core@npm:^7.11.6, @babel/core@npm:^7.12.3, @babel/core@npm:^7.20.0, @babel/core@npm:^7.21.3, @babel/core@npm:^7.23.9, @babel/core@npm:^7.25.1, @babel/core@npm:^7.25.2, @babel/core@npm:^7.27.4, @babel/core@npm:^7.29.0":
6464
version: 7.29.0
6565
resolution: "@babel/core@npm:7.29.0"
6666
dependencies:
@@ -14472,6 +14472,8 @@ __metadata:
1447214472
version: 0.0.0-use.local
1447314473
resolution: "react-native-executorch-monorepo@workspace:."
1447414474
dependencies:
14475+
"@babel/core": "npm:^7.25.1"
14476+
"@babel/eslint-parser": "npm:^7.25.1"
1447514477
"@cspell/eslint-plugin": "npm:^8.19.0"
1447614478
"@evilmartians/lefthook": "npm:^2.1.1"
1447714479
"@react-native/eslint-config": "npm:^0.79.0"
@@ -14481,7 +14483,6 @@ __metadata:
1448114483
eslint-plugin-jsdoc: "npm:^62.7.1"
1448214484
eslint-plugin-markdown: "npm:^5.1.0"
1448314485
eslint-plugin-prettier: "npm:^5.0.1"
14484-
expo-router: "npm:~6.0.17"
1448514486
prettier: "npm:^3.3.3"
1448614487
prettier-plugin-jsdoc: "npm:^1.3.0"
1448714488
typescript: "npm:~5.9.2"

0 commit comments

Comments
 (0)