refactor: add missing comments

Author: NorbertKlockiewicz

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.h

@@ -1,8 +1,5 @@
 #pragma once
 
-// NOTE: This header must NOT include <jsi/jsi.h> — it is used in JSI-free unit
-// tests.
-
 #include <array>
 #include <opencv2/opencv.hpp>
 #include <string>
@@ -12,9 +9,12 @@ namespace rnexecutorch::utils {
 enum class Orientation { Up, Down, Left, Right };
 
 inline Orientation orientationFromString(const std::string &s) {
-  if (s == "down") return Orientation::Down;
-  if (s == "left") return Orientation::Left;
-  if (s == "right") return Orientation::Right;
+  if (s == "down")
+    return Orientation::Down;
+  if (s == "left")
+    return Orientation::Left;
+  if (s == "right")
+    return Orientation::Right;
   return Orientation::Up;
 }
 
@@ -91,7 +91,8 @@ void inverseRotatePoints(std::array<P, 4> &points,
 
 #if defined(__APPLE__)
   if (orient.isMirrored) {
-    bool swapped = (orient.orientation == Orientation::Up || orient.orientation == Orientation::Down);
+    bool swapped = (orient.orientation == Orientation::Up ||
+                    orient.orientation == Orientation::Down);
     float sw = swapped ? h : w;
     float sh = swapped ? w : h;
     for (auto &p : points) {

packages/react-native-executorch/src/hooks/computer_vision/useOCR.ts

@@ -35,12 +35,17 @@ export const useOCR = ({ model, preventLoad = false }: OCRProps): OCRType => {
 
     if (preventLoad) return;
 
-    controller.load(
-      model.detectorSource,
-      model.recognizerSource,
-      model.language,
-      setDownloadProgress
-    );
+    controller
+      .load(
+        model.detectorSource,
+        model.recognizerSource,
+        model.language,
+        setDownloadProgress
+      )
+      .then(() => {
+        const worklet = controller.runOnFrame;
+        if (worklet) setRunOnFrame(() => worklet);
+      });
 
     return () => {
       setRunOnFrame(null);
@@ -57,15 +62,6 @@ export const useOCR = ({ model, preventLoad = false }: OCRProps): OCRType => {
     preventLoad,
   ]);
 
-  useEffect(() => {
-    if (!isReady) {
-      setRunOnFrame(null);
-      return;
-    }
-    const worklet = controller.runOnFrame;
-    if (worklet) setRunOnFrame(() => worklet);
-  }, [controller, isReady]);
-
   const forward = useCallback(
     (imageSource: string | PixelData): Promise<OCRDetection[]> =>
       controller.forward(imageSource),

packages/react-native-executorch/src/hooks/computer_vision/useVerticalOCR.ts

@@ -40,13 +40,18 @@ export const useVerticalOCR = ({
 
     if (preventLoad) return;
 
-    controller.load(
-      model.detectorSource,
-      model.recognizerSource,
-      model.language,
-      independentCharacters,
-      setDownloadProgress
-    );
+    controller
+      .load(
+        model.detectorSource,
+        model.recognizerSource,
+        model.language,
+        independentCharacters,
+        setDownloadProgress
+      )
+      .then(() => {
+        const worklet = controller.runOnFrame;
+        if (worklet) setRunOnFrame(() => worklet);
+      });
 
     return () => {
       setRunOnFrame(null);
@@ -64,15 +69,6 @@ export const useVerticalOCR = ({
     preventLoad,
   ]);
 
-  useEffect(() => {
-    if (!isReady) {
-      setRunOnFrame(null);
-      return;
-    }
-    const worklet = controller.runOnFrame;
-    if (worklet) setRunOnFrame(() => worklet);
-  }, [controller, isReady]);
-
   const forward = useCallback(
     (imageSource: string | PixelData): Promise<OCRDetection[]> =>
       controller.forward(imageSource),

packages/react-native-executorch/src/types/objectDetection.ts

@@ -139,6 +139,7 @@ export interface ObjectDetectionType<L extends LabelEnum> {
    * Available after model is loaded (`isReady: true`).
    *
    * @param frame - VisionCamera Frame object
+   * @param isFrontCamera - Whether the front camera is active, used for mirroring corrections.
    * @param detectionThreshold - The threshold for detection sensitivity.
    * @returns Array of Detection objects representing detected items in the frame.
    */

packages/react-native-executorch/src/types/ocr.ts

@@ -136,6 +136,7 @@ export interface OCRType {
    * Available after model is loaded (`isReady: true`).
    *
    * @param frame - VisionCamera Frame object
+   * @param isFrontCamera - Whether the front camera is active, used for mirroring corrections.
    * @returns Array of OCRDetection results for the frame.
    */
   runOnFrame: ((frame: Frame, isFrontCamera: boolean) => OCRDetection[]) | null;

packages/react-native-executorch/src/types/semanticSegmentation.ts

@@ -177,6 +177,7 @@ export interface SemanticSegmentationType<L extends LabelEnum> {
    * Available after model is loaded (`isReady: true`).
    *
    * @param frame - VisionCamera Frame object
+   * @param isFrontCamera - Whether the front camera is active, used for mirroring corrections.
    * @param classesOfInterest - Labels for which to return per-class probability masks.
    * @param resizeToInput - Whether to resize masks to original frame dimensions. Defaults to `true`.
    * @returns Object with `ARGMAX` Int32Array and per-class Float32Array masks.

packages/react-native-executorch/src/types/styleTransfer.ts

@@ -86,6 +86,7 @@ export interface StyleTransferType {
    * Available after model is loaded (`isReady: true`).
    *
    * @param frame - VisionCamera Frame object
+   * @param isFrontCamera - Whether the front camera is active, used for mirroring corrections.
    * @returns PixelData containing the stylized frame as raw RGB pixel data.
    */
   runOnFrame: ((frame: Frame, isFrontCamera: boolean) => PixelData) | null;