fix: use & instead of *

Author: NorbertKlockiewicz

packages/react-native-executorch/common/runner/multimodal_decoder_runner.h

@@ -16,7 +16,7 @@
 namespace executorch::extension::llm {
 class MultimodalDecoderRunner : public TextDecoderRunner {
 public:
-  explicit MultimodalDecoderRunner(Module *module, IOManager *io_manager)
+  explicit MultimodalDecoderRunner(Module &module, IOManager *io_manager)
       : TextDecoderRunner(module, io_manager) {}
 
   inline ::executorch::runtime::Result<::executorch::aten::Tensor>

packages/react-native-executorch/common/runner/multimodal_runner.cpp

@@ -44,8 +44,8 @@ Error MultimodalRunner::load_subcomponents() {
 
   Stats *stats_ptr = &stats_;
 
-  mm_decoder_runner_ = std::make_unique<MultimodalDecoderRunner>(
-      module_.get(), io_manager_.get());
+  mm_decoder_runner_ =
+      std::make_unique<MultimodalDecoderRunner>(*module_, io_manager_.get());
   IEncoder *image_encoder = nullptr;
   auto enc_it = encoders_.find(MultimodalType::Image);
   if (enc_it != encoders_.end()) {

packages/react-native-executorch/common/runner/text_decoder_runner.cpp

@@ -21,9 +21,9 @@ namespace llm {
 // NOTE: we observed ~2x loading performance increase on iPhone 15
 // and a ~5% improvement on Galaxy S22 by switching to
 // FileDataLoader instead of MmapDataLoader + UseMlockIgnoreErrors.
-TextDecoderRunner::TextDecoderRunner(Module *module, IOManager *io_manager,
+TextDecoderRunner::TextDecoderRunner(Module &module, IOManager *io_manager,
                                      float temperature, float topp)
-    : module_(module), io_manager_(io_manager), temperature_(temperature),
+    : module_(&module), io_manager_(io_manager), temperature_(temperature),
       topp_(topp) {}
 
 // This function is functional, meaning it shouldn't modify any state of the

packages/react-native-executorch/common/runner/text_decoder_runner.h

@@ -19,7 +19,7 @@ namespace llm {
 
 class TextDecoderRunner {
 public:
-  explicit TextDecoderRunner(Module *module, IOManager *io_manager,
+  explicit TextDecoderRunner(Module &module, IOManager *io_manager,
                              float temperature = 0.8F, float topp = 0.9F);
 
   virtual ~TextDecoderRunner() = default;
@@ -99,13 +99,7 @@ class TextDecoderRunner {
   }
 
 protected:
-  /**
-   * Note: TextDecoderRunner does not own the Module or IOManager instance. It
-   * is expected that the outer class (likely Runner) manages the lifecycle of
-   * them. This means that the responsibility for creating, maintaining, and
-   * destroying the Module lies outside of TextDecoderRunner. Ensure that the
-   * Module remains valid for the duration of TextDecoderRunner's usage.
-   */
+  // Non-owning. The runner (BaseLLMRunner) owns the Module and outlives this.
   Module *module_;
   IOManager *io_manager_;
   bool should_stop_{false};

packages/react-native-executorch/common/runner/text_runner.cpp

@@ -28,7 +28,7 @@ Error TextRunner::load_subcomponents() {
   Stats *stats_ptr = &stats_;
 
   text_decoder_runner_ = std::make_unique<TextDecoderRunner>(
-      module_.get(), io_manager_.get(), config_.temperature, config_.topp);
+      *module_, io_manager_.get(), config_.temperature, config_.topp);
   text_prefiller_ = std::make_unique<TextPrefiller>(
       text_decoder_runner_.get(), config_.enable_kv_cache,
       config_.enable_dynamic_shape, config_.max_seq_len);