review fix

Author: Mateusz Kopciński

packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h

@@ -66,7 +66,8 @@ inline JSTensorViewIn getValue<JSTensorViewIn>(const jsi::Value &val,
   tensorView.sizes.reserve(numShapeDims);
 
   for (size_t i = 0; i < numShapeDims; ++i) {
-    int32_t dim = getValue<int32_t>(shapeArray.getValueAtIndex(runtime, i), runtime);
+    int32_t dim =
+        getValue<int32_t>(shapeArray.getValueAtIndex(runtime, i), runtime);
     tensorView.sizes.push_back(dim);
   }
 
@@ -173,23 +174,24 @@ inline std::vector<T> getArrayAsVector(const jsi::Value &val,
   return result;
 }
 
-
 // Template specializations for std::vector<T> types
 template <>
-inline std::vector<JSTensorViewIn> getValue<std::vector<JSTensorViewIn>>(const jsi::Value &val,
-                                                       jsi::Runtime &runtime) {
+inline std::vector<JSTensorViewIn>
+getValue<std::vector<JSTensorViewIn>>(const jsi::Value &val,
+                                      jsi::Runtime &runtime) {
   return getArrayAsVector<JSTensorViewIn>(val, runtime);
 }
 
 template <>
-inline std::vector<std::string> getValue<std::vector<std::string>>(const jsi::Value &val,
-                                                       jsi::Runtime &runtime) {
+inline std::vector<std::string>
+getValue<std::vector<std::string>>(const jsi::Value &val,
+                                   jsi::Runtime &runtime) {
   return getArrayAsVector<std::string>(val, runtime);
 }
 
 template <>
-inline std::vector<int32_t> getValue<std::vector<int32_t>>(const jsi::Value &val,
-                                                       jsi::Runtime &runtime) {
+inline std::vector<int32_t>
+getValue<std::vector<int32_t>>(const jsi::Value &val, jsi::Runtime &runtime) {
   return getArrayAsVector<int32_t>(val, runtime);
 }
 
@@ -284,7 +286,7 @@ inline jsi::Value getJsiValue(const std::vector<char> &vec,
                               jsi::Runtime &runtime) {
   jsi::Array array(runtime, vec.size());
   for (size_t i = 0; i < vec.size(); i++) {
-    array.setValueAtIndex(runtime, i, jsi::Value(static_cast<char>(vec[i])));
+    array.setValueAtIndex(runtime, i, jsi::Value(vec[i]));
   }
   return {runtime, array};
 }

packages/react-native-executorch/common/rnexecutorch/models/speech_to_text/SpeechToText.cpp

@@ -1,7 +1,6 @@
 #include <thread>
 
 #include "SpeechToText.h"
-#include <vector>
 
 namespace rnexecutorch::models::speech_to_text {
 
@@ -43,7 +42,7 @@ SpeechToText::decode(std::span<int32_t> tokens,
 }
 
 std::vector<char> SpeechToText::transcribe(std::span<float> waveform,
-                                     std::string languageOption) const {
+                                           std::string languageOption) const {
   std::vector<Segment> segments =
       this->asr->transcribe(waveform, DecodingOptions(languageOption));
   std::string transcription;
@@ -62,8 +61,7 @@ std::vector<char> SpeechToText::transcribe(std::span<float> waveform,
     }
   }
 
-  std::vector<char> charVector(transcription.begin(), transcription.end());
-  return charVector;
+  return {transcription.begin(), transcription.end()};
 }
 
 size_t SpeechToText::getMemoryLowerBound() const noexcept {
@@ -77,16 +75,17 @@ void SpeechToText::stream(std::shared_ptr<jsi::Function> callback,
     throw std::runtime_error("Streaming is already in progress");
   }
 
-  auto nativeCallback = [this, callback](const std::vector<char> &committedVec,
-                                         const std::vector<char> &nonCommittedVec,
-                                         bool isDone) {
-    this->callInvoker->invokeAsync(
-        [callback, committedVec, nonCommittedVec, isDone](jsi::Runtime &rt) {
-          callback->call(rt, rnexecutorch::jsi_conversion::getJsiValue(committedVec, rt),
-                         rnexecutorch::jsi_conversion::getJsiValue(nonCommittedVec, rt),
-                         jsi::Value(isDone));
+  auto nativeCallback =
+      [this, callback](const std::vector<char> &committedVec,
+                       const std::vector<char> &nonCommittedVec, bool isDone) {
+        this->callInvoker->invokeAsync([callback, committedVec, nonCommittedVec,
+                                        isDone](jsi::Runtime &rt) {
+          callback->call(
+              rt, rnexecutorch::jsi_conversion::getJsiValue(committedVec, rt),
+              rnexecutorch::jsi_conversion::getJsiValue(nonCommittedVec, rt),
+              jsi::Value(isDone));
         });
-  };
+      };
 
   this->isStreaming = true;
   while (this->isStreaming) {
@@ -98,17 +97,14 @@ void SpeechToText::stream(std::shared_ptr<jsi::Function> callback,
     ProcessResult res =
         this->processor->processIter(DecodingOptions(languageOption));
 
-    std::vector<char> committedVec(res.committed.begin(), res.committed.end());
-    std::vector<char> nonCommittedVec(res.nonCommitted.begin(), res.nonCommitted.end());
-
-    nativeCallback(committedVec, nonCommittedVec, false);
+    nativeCallback({res.committed.begin(), res.committed.end()},
+                   {res.nonCommitted.begin(), res.nonCommitted.end()}, false);
     this->readyToProcess = false;
   }
 
   std::string committed = this->processor->finish();
-  std::vector<char> committedVec(committed.begin(), committed.end());
 
-  nativeCallback(committedVec, {}, true);
+  nativeCallback({committed.begin(), committed.end()}, {}, true);
 
   this->resetStreamState();
 }