fix: address C++ comments

Author: JakubGonera

common/rnexecutorch/data_processing/ImageProcessing.cpp

@@ -49,13 +49,13 @@ cv::Mat bufferToColorMat(const std::span<const float> &buffer,
   for (int i = 0; i < pixelCount; i++) {
     int row = i / matSize.width;
     int col = i % matSize.width;
-    float r = 0, g = 0, b = 0;
 
-    r = buffer[0 * pixelCount + i];
-    g = buffer[1 * pixelCount + i];
-    b = buffer[2 * pixelCount + i];
+    float r = buffer[0 * pixelCount + i];
+    float g = buffer[1 * pixelCount + i];
+    float b = buffer[2 * pixelCount + i];
 
-    cv::Vec3b color((uchar)(b * 255), (uchar)(g * 255), (uchar)(r * 255));
+    cv::Vec3b color(static_cast<uchar>(b * 255), static_cast<uchar>(g * 255),
+                    static_cast<uchar>(r * 255));
     mat.at<cv::Vec3b>(row, col) = color;
   }
 

common/rnexecutorch/host_objects/ModelHostObject.h

@@ -1,3 +1,4 @@
+#include <cstdio>
 #include <string>
 #include <tuple>
 #include <vector>
@@ -27,7 +28,13 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
             constexpr std::size_t forwardArgCount =
                 jsiconversion::getArgumentCount(&Model::forward);
             if (forwardArgCount != count) {
-              promise->reject("Argument count mismatch");
+              char errorMessage[100];
+              std::snprintf(
+                  errorMessage, sizeof(errorMessage),
+                  "Argument count mismatch, was expecting: %zu but got: %zu",
+                  forwardArgCount, count);
+
+              promise->reject(errorMessage);
               return;
             }
 

common/rnexecutorch/models/BaseModel.cpp

@@ -32,10 +32,7 @@ std::vector<int32_t> BaseModel::getInputShape() {
   }
 
   auto shape = input_meta->sizes();
-  std::vector<int32_t> output(shape.size());
-  for (int i = 0; i < shape.size(); i++) {
-    output[i] = shape[i];
-  }
+  std::vector<int32_t> output(shape.begin(), shape.end());
 
   return output;
 }