build: bump executorch to v1.2.0 (#1076)

## Description

Updates ExecuTorch binaries and header files to version v1.2.0

### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [x] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [x] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

- [ ] Run tests from
`packages/react-native-executorch/common/rnexecutorch/tests`.
- [ ] Build all example apps on both Android and iOS and verify that
models work as expected.

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

Closes #1057

### Checklist

- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

The binaries were built from
https://github.com/barhanc/executorch/tree/rne-build-v1.2.0. The header
files also come from there.

Author: barhanc

packages/react-native-executorch/android/CMakeLists.txt

@@ -26,5 +26,7 @@ set(INCLUDE_DIR "${CMAKE_SOURCE_DIR}/../third-party/include")
 
 # Treat third-party headers as system headers to suppress deprecation warnings
 include_directories(SYSTEM "${INCLUDE_DIR}")
+include_directories(SYSTEM "${INCLUDE_DIR}/cpuinfo")
+include_directories(SYSTEM "${INCLUDE_DIR}/pthreadpool")
 
 add_subdirectory("${ANDROID_CPP_DIR}")

packages/react-native-executorch/android/libs/classes.jar

@@ -115,6 +115,8 @@ target_include_directories(rntests_core PUBLIC
     ${RNEXECUTORCH_DIR}
     ${COMMON_DIR}
     ${PACKAGE_ROOT}/third-party/include
+    ${PACKAGE_ROOT}/third-party/include/cpuinfo
+    ${PACKAGE_ROOT}/third-party/include/pthreadpool
     ${REACT_NATIVE_DIR}/ReactCommon
     ${REACT_NATIVE_DIR}/ReactCommon/jsi
     ${REACT_NATIVE_DIR}/ReactCommon/callinvoker

packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt

@@ -19,7 +19,10 @@ Pod::Spec.new do |s|
   phonemis_binaries_path = File.expand_path('$(PODS_TARGET_SRCROOT)/third-party/ios/libs/phonemis', __dir__)
 
   s.user_target_xcconfig = {
-    "HEADER_SEARCH_PATHS" => "$(PODS_TARGET_SRCROOT)/third-party/include",
+    "HEADER_SEARCH_PATHS" =>
+      '"$(PODS_TARGET_SRCROOT)/third-party/include" '+
+      '"$(PODS_TARGET_SRCROOT)/third-party/include/cpuinfo" '+
+      '"$(PODS_TARGET_SRCROOT)/third-party/include/pthreadpool"',
 
     "OTHER_LDFLAGS[sdk=iphoneos*]" => [
       '$(inherited)',
@@ -45,6 +48,8 @@ Pod::Spec.new do |s|
       '"$(PODS_TARGET_SRCROOT)/ios" '+
       '"$(PODS_TARGET_SRCROOT)/third-party/include/executorch/extension/llm/tokenizers/include" '+
       '"$(PODS_TARGET_SRCROOT)/third-party/include" '+
+      '"$(PODS_TARGET_SRCROOT)/third-party/include/cpuinfo" '+
+      '"$(PODS_TARGET_SRCROOT)/third-party/include/pthreadpool" '+
       '"$(PODS_TARGET_SRCROOT)/common" ',
     "CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
     'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'x86_64',

packages/react-native-executorch/react-native-executorch.podspec

@@ -8,6 +8,7 @@
 
 #pragma once
 
+#include <c10/util/safe_numerics.h>
 #include <cstring>
 #include <executorch/runtime/core/data_loader.h>
 #include <executorch/runtime/core/error.h>
@@ -33,7 +34,9 @@ class BufferDataLoader final : public executorch::runtime::DataLoader {
   executorch::runtime::Result<executorch::runtime::FreeableBuffer>
   load(size_t offset, size_t size,
        ET_UNUSED const DataLoader::SegmentInfo &segment_info) const override {
-    ET_CHECK_OR_RETURN_ERROR(offset + size <= size_, InvalidArgument,
+    size_t total_size;
+    bool overflow = c10::add_overflows(offset, size, &total_size);
+    ET_CHECK_OR_RETURN_ERROR(!overflow && total_size <= size_, InvalidArgument,
                              "offset %zu + size %zu > size_ %zu", offset, size,
                              size_);
     return executorch::runtime::FreeableBuffer(data_ + offset, size,

packages/react-native-executorch/third-party/android/libs/executorch/arm64-v8a/libexecutorch.so

@@ -80,4 +80,4 @@ class HFTokenizer : public Tokenizer {
   Model::Ptr _model;
 };
 
-} // namespace tokenizers
+} // namespace tokenizers

packages/react-native-executorch/third-party/android/libs/executorch/x86_64/libexecutorch.so

@@ -148,4 +148,4 @@ class ModelConfig {
   Model::Ptr create() const;
 };
 
-} // namespace tokenizers
+} // namespace tokenizers

packages/react-native-executorch/third-party/include/executorch/extension/data_loader/buffer_data_loader.h

@@ -89,4 +89,4 @@ class TruncationConfig {
   TruncationParams params;
 };
 
-} // namespace tokenizers
+} // namespace tokenizers