Skip to content

Commit b55a21f

Browse files
authored
fix: remove CxxModuleWrapper include (#993)
## Description This PR removes usage of a header which was removed in RN 84. The usage of this header, crashed compilation of Android apps using RN >= 84 ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [x] Android ### Testing instructions - [x] Create a bare RN app with RN 84 - [x] Verify Android compiles on this branch, but doesnt on `0.8.0-nightly-bf29217-20260323` - [x] Verify that this branch works also with RN 81 ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
1 parent 0d468b7 commit b55a21f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

docs/docs/07-other/01-compatibility.mdx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
1717
<thead>
1818
<tr>
1919
<th rowSpan={2}>React Native ExecuTorch</th>
20-
<th colSpan={6}>React Native version</th>
20+
<th colSpan={7}>React Native version</th>
2121
</tr>
2222
<tr>
2323
<th>0.78</th>
@@ -26,6 +26,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
2626
<th>0.81</th>
2727
<th>0.82</th>
2828
<th>0.83</th>
29+
<th>0.84</th>
2930
</tr>
3031
</thead>
3132
<tbody>
@@ -37,6 +38,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
3738
<td><div className={styles.supported}>yes</div></td>
3839
<td><div className={styles.supported}>yes</div></td>
3940
<td><div className={styles.supported}>yes</div></td>
41+
<td><div className={styles.supported}>yes</div></td>
4042
</tr>
4143
</tbody>
4244
</table>
@@ -49,7 +51,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
4951
<thead>
5052
<tr>
5153
<th rowSpan={2}>Bare Resource Fetcher</th>
52-
<th colSpan={6}>React Native version</th>
54+
<th colSpan={7}>React Native version</th>
5355
</tr>
5456
<tr>
5557
<th>0.78</th>
@@ -58,6 +60,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
5860
<th>0.81</th>
5961
<th>0.82</th>
6062
<th>0.83</th>
63+
<th>0.84</th>
6164
</tr>
6265
</thead>
6366
<tbody>
@@ -69,6 +72,7 @@ React Native ExecuTorch supports only the [New Architecture](https://reactnative
6972
<td><div className={styles.supported}>yes</div></td>
7073
<td><div className={styles.supported}>yes</div></td>
7174
<td><div className={styles.supported}>yes</div></td>
75+
<td><div className={styles.supported}>yes</div></td>
7276
</tr>
7377
</tbody>
7478
</table>

packages/react-native-executorch/android/src/main/cpp/ETInstallerModule.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
#include <ReactCommon/CallInvokerHolder.h>
44
#include <fbjni/fbjni.h>
5-
#include <react/jni/CxxModuleWrapper.h>
65
#include <react/jni/JMessageQueueThread.h>
76

87
#include <memory>
@@ -40,4 +39,4 @@ class ETInstallerModule : public jni::HybridClass<ETInstallerModule> {
4039
const std::shared_ptr<facebook::react::CallInvoker> &jsCallInvoker);
4140
};
4241

43-
} // namespace rnexecutorch
42+
} // namespace rnexecutorch

0 commit comments

Comments
 (0)