Skip to content

Commit b6c5884

Browse files
Fix: stop yarn typecheck from creating .js files inside project. (#522)
## Description Commit fea6dbf introduced a modification to `package.json` that caused an issue during the pre-commit hook. Specifically, after this change, running `yarn typecheck` on any modified `.ts` file within `packages/react-native-executorch` would emit a corresponding `.js` file. Adding the `--noEmit` flag to the `yarn typecheck` command, prevents these extra files from being created. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
1 parent d4b1132 commit b6c5884

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native-executorch/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
],
3232
"scripts": {
3333
"example": "yarn workspace react-native-executorch-example",
34-
"typecheck": "tsc",
34+
"typecheck": "tsc --noEmit",
3535
"lint": "eslint \"**/*.{js,ts,tsx}\"",
3636
"clean": "del-cli android/build example/android/build example/android/app/build example/ios/build lib",
3737
"prepare": "bob build"

0 commit comments

Comments
 (0)