fix: naming

Author: JakubGonera

packages/react-native-executorch/common/rnexecutorch/data_processing/ImageProcessing.cpp

@@ -114,10 +114,10 @@ cv::Mat readImage(const std::string &imageURI) {
   return image;
 }
 
-TensorPtr getTensorFromMatrix(const std::vector<int32_t> &tensorDim,
+TensorPtr getTensorFromMatrix(const std::vector<int32_t> &tensorDims,
                               const cv::Mat &matrix) {
   std::vector<float> inputVector = colorMatToVector(matrix);
-  return executorch::extension::make_tensor_ptr(tensorDim, inputVector);
+  return executorch::extension::make_tensor_ptr(tensorDims, inputVector);
 }
 
 cv::Mat getMatrixFromTensor(cv::Size size, const Tensor &tensor) {
@@ -128,26 +128,26 @@ cv::Mat getMatrixFromTensor(cv::Size size, const Tensor &tensor) {
 
 std::pair<TensorPtr, cv::Size>
 readImageToTensor(const std::string &path,
-                  const std::vector<int32_t> &tensorDim) {
+                  const std::vector<int32_t> &tensorDims) {
   cv::Mat input = imageprocessing::readImage(path);
   cv::Size imageSize = input.size();
 
-  if (tensorDim.size() < 2) {
+  if (tensorDims.size() < 2) {
     char errorMessage[100];
     std::snprintf(errorMessage, sizeof(errorMessage),
                   "Unexpected tensor size, expected at least 2 dimentions "
                   "but got: %zu.",
-                  tensorDim.size());
+                  tensorDims.size());
     throw std::runtime_error(errorMessage);
   }
-  cv::Size tensorSize = cv::Size(tensorDim[tensorDim.size() - 1],
-                                 tensorDim[tensorDim.size() - 2]);
+  cv::Size tensorSize = cv::Size(tensorDims[tensorDims.size() - 1],
+                                 tensorDims[tensorDims.size() - 2]);
 
   cv::resize(input, input, tensorSize);
 
   cv::cvtColor(input, input, cv::COLOR_BGR2RGB);
 
-  return {imageprocessing::getTensorFromMatrix(tensorDim, input), imageSize};
+  return {imageprocessing::getTensorFromMatrix(tensorDims, input), imageSize};
 }
 } // namespace imageprocessing
 } // namespace rnexecutorch

packages/react-native-executorch/common/rnexecutorch/data_processing/ImageProcessing.h

@@ -26,13 +26,13 @@ cv::Mat bufferToColorMat(const std::span<const float> &buffer,
 std::string saveToTempFile(const cv::Mat &image);
 /// @brief Read image in a BGR format to a cv::Mat
 cv::Mat readImage(const std::string &imageURI);
-TensorPtr getTensorFromMatrix(const std::vector<int32_t> &tensorDim,
+TensorPtr getTensorFromMatrix(const std::vector<int32_t> &tensorDims,
                               const cv::Mat &mat);
 cv::Mat getMatrixFromTensor(cv::Size size, const Tensor &tensor);
 /// @brief Read image, resize it and copy it to an ET tensor to store it.
 /// @return Returns a tensor pointer and the original size of the image.
 std::pair<TensorPtr, cv::Size>
 readImageToTensor(const std::string &path,
-                  const std::vector<int32_t> &tensorDim);
+                  const std::vector<int32_t> &tensorDims);
 
 } // namespace rnexecutorch::imageprocessing

packages/react-native-executorch/common/rnexecutorch/models/classification/Classification.cpp

@@ -30,10 +30,10 @@ Classification::Classification(const std::string &modelSource,
 
 std::unordered_map<std::string_view, float>
 Classification::forward(std::string imageSource) {
-  auto tensor =
+  auto inputTensor =
       imageprocessing::readImageToTensor(imageSource, getInputShape()[0]).first;
 
-  auto forwardResult = forwardET(tensor);
+  auto forwardResult = forwardET(inputTensor);
   if (!forwardResult.ok()) {
     throw std::runtime_error(
         "Failed to forward, error: " +

packages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp

@@ -65,10 +65,10 @@ ObjectDetection::postprocess(const std::vector<EValue> &tensors,
 
 std::vector<Detection> ObjectDetection::forward(std::string imageSource,
                                                 double detectionThreshold) {
-  auto [tensor, originalSize] =
+  auto [inputTensor, originalSize] =
       imageprocessing::readImageToTensor(imageSource, getInputShape()[0]);
 
-  auto forwardResult = forwardET(tensor);
+  auto forwardResult = forwardET(inputTensor);
   if (!forwardResult.ok()) {
     throw std::runtime_error(
         "Failed to forward, error: " +

packages/react-native-executorch/common/rnexecutorch/models/style_transfer/StyleTransfer.cpp

@@ -42,10 +42,10 @@ std::string StyleTransfer::postprocess(const Tensor &tensor,
 }
 
 std::string StyleTransfer::forward(std::string imageSource) {
-  auto [tensor, originalSize] =
+  auto [inputTensor, originalSize] =
       imageprocessing::readImageToTensor(imageSource, getInputShape()[0]);
 
-  auto forwardResult = forwardET(tensor);
+  auto forwardResult = forwardET(inputTensor);
   if (!forwardResult.ok()) {
     throw std::runtime_error(
         "Failed to forward, error: " +