fix: address some of the review comments

Author: JakubGonera

common/rnexecutorch/RnExecutorchInstaller.cpp

@@ -7,6 +7,9 @@
 
 namespace rnexecutorch {
 
+// This function fetches data from a url address. It is implemented in
+// Kotlin/ObjectiveC++ and then bound to this variable. It's done to not handle
+// SSL intricacies manually, as it is done automagically in ObjC++/Kotlin.
 FetchUrlFunc_t fetchUrlFunc;
 
 jsi::Function RnExecutorchInstaller::loadStyleTransfer(

common/rnexecutorch/jsi/JsiHostObject.cpp

@@ -77,19 +77,19 @@ jsi::Value JsiHostObject::get(jsi::Runtime &runtime,
   }
 
   auto function = functions_->find(nameAsString);
-  if (function != functions_->end()) {
-    auto dispatcher =
-        std::bind(function->second, reinterpret_cast<JsiHostObject *>(this),
-                  std::placeholders::_1, std::placeholders::_2,
-                  std::placeholders::_3, std::placeholders::_4);
-
-    return hostFunctionCache
-        .emplace(nameAsString, jsi::Function::createFromHostFunction(
-                                   runtime, name, 0, dispatcher))
-        .first->second.asFunction(runtime);
+  if (function == functions_->end()) {
+    return jsi::Value::undefined();
   }
 
-  return jsi::Value::undefined();
+  auto dispatcher =
+      std::bind(function->second, reinterpret_cast<JsiHostObject *>(this),
+                std::placeholders::_1, std::placeholders::_2,
+                std::placeholders::_3, std::placeholders::_4);
+
+  return hostFunctionCache
+      .emplace(nameAsString, jsi::Function::createFromHostFunction(
+                                 runtime, name, 0, dispatcher))
+      .first->second.asFunction(runtime);
 }
 
 void JsiHostObject::set(jsi::Runtime &runtime, const jsi::PropNameID &name,

src/hooks/computer_vision/useStyleTransfer.ts

@@ -4,12 +4,12 @@ import { StyleTransferModule } from '../../modules/computer_vision/StyleTransfer
 
 interface Props {
   modelSource: ResourceSource;
-  doNotLoad?: boolean;
+  preventLoad?: boolean;
 }
 
-export const useStyleTransfer = ({ modelSource, doNotLoad = false }: Props) =>
+export const useStyleTransfer = ({ modelSource, preventLoad = false }: Props) =>
   useNonStaticModule({
     module: StyleTransferModule,
     loadArgs: [modelSource],
-    doNotLoad: doNotLoad,
+    preventLoad: preventLoad,
   });

src/hooks/useNonStaticModule.ts

@@ -18,11 +18,11 @@ export const useNonStaticModule = <
 >({
   module,
   loadArgs,
-  doNotLoad = false,
+  preventLoad = false,
 }: {
   module: ModuleConstructor<M>;
   loadArgs: LoadArgs;
-  doNotLoad?: boolean;
+  preventLoad?: boolean;
 }) => {
   const [error, setError] = useState<null | string>(null);
   const [isReady, setIsReady] = useState(false);
@@ -31,7 +31,7 @@ export const useNonStaticModule = <
   const model = useMemo(() => new module(), [module]);
 
   useEffect(() => {
-    if (!doNotLoad) {
+    if (!preventLoad) {
       (async () => {
         setDownloadProgress(0);
         setError(null);
@@ -45,7 +45,7 @@ export const useNonStaticModule = <
       })();
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [...loadArgs, doNotLoad]);
+  }, [...loadArgs, preventLoad]);
 
   const forward = async (...input: ForwardArgs): Promise<ForwardReturn> => {
     if (!isReady) throw new Error(getError(ETError.ModuleNotLoaded));