chore: 🧹✨

Author: chmjkb

packages/react-native-executorch/common/rnexecutorch/TypeConcepts.h

@@ -0,0 +1,35 @@
+#pragma once
+
+#include <concepts>
+
+namespace rnexecutorch {
+
+// When i make BaseModel have all of this methods we can then just check from
+// is_base_of instead of doing this for every single method
+template <typename T>
+concept HasForward = requires(T t) {
+  { &T::forward };
+};
+
+template <typename T>
+concept HasMethodNames = requires(T t) {
+  { &T::methodNames };
+};
+
+template <typename T>
+concept HasGetInputShape = requires(T t) {
+  { &T::getInputShape };
+};
+
+template <typename T>
+concept HasIsLoaded = requires(T t) {
+  { &T::isLoaded };
+};
+
+template <typename T>
+concept UnloadableExternalMemoryAware = requires(T t) {
+  { t.unload() } -> std::same_as<void>;
+  { t.getMemoryLowerBound() } -> std::same_as<std::size_t>;
+};
+
+} // namespace rnexecutorch

packages/react-native-executorch/common/rnexecutorch/bindings/ExecutorchModule.h

@@ -4,8 +4,6 @@
 
 #include <ReactCommon/CallInvoker.h>
 #include <executorch/extension/module/module.h>
-#include <filesystem>
-#include <jsi/jsi.h>
 #include <rnexecutorch/jsi/OwningArrayBuffer.h>
 #include <rnexecutorch/utils/JsiTensorView.h>
 

packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h

@@ -19,7 +19,7 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
 public:
   explicit ModelHostObject(const std::shared_ptr<Model> &model,
                            std::shared_ptr<react::CallInvoker> callInvoker)
-      : JsiHostObject(), model(model), callInvoker(callInvoker) {
+      : model(model), callInvoker(callInvoker) {
     if constexpr (UnloadableExternalMemoryAware<Model>) {
       addFunctions(
           JSI_EXPORT_FUNCTION(ModelHostObject<Model>, unload, "unload"));