fix: correctly transform bounding boxes

Author: NorbertKlockiewicz

apps/computer-vision/components/vision_camera/tasks/ObjectDetectionTask.tsx

@@ -80,11 +80,9 @@ export default function ObjectDetectionTask({
         }
         try {
           if (!detRof) return;
-          const orientation = frame.orientation;
-          // "up"/"down" = landscape orientations where buffer axes are swapped vs screen
-          const swapAxes = orientation === 'up' || orientation === 'down';
-          const screenW = swapAxes ? frame.height : frame.width;
-          const screenH = swapAxes ? frame.width : frame.height;
+          // C++ always does CW rotation, so output space is always frameH × frameW
+          const screenW = frame.height;
+          const screenH = frame.width;
           const result = detRof(frame, cameraPositionSync.getDirty(), 0.5);
           if (result) {
             scheduleOnRN(updateDetections, {

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.cpp

@@ -34,9 +34,9 @@ void transformBbox(float &x1, float &y1, float &x2, float &y2,
     x1 = nx1; y1 = ny1;
     x2 = nx2; y2 = ny2;
   } else if (orient.orientation == "left") {
-    // CCW: new_x = y, new_y = w - x
-    float nx1 = y1, ny1 = w - x2;
-    float nx2 = y2, ny2 = w - x1;
+    // CW: new_x = h - y, new_y = x
+    float nx1 = h - y2, ny1 = x1;
+    float nx2 = h - y1, ny2 = x2;
     x1 = nx1; y1 = ny1;
     x2 = nx2; y2 = ny2;
   } else {

packages/react-native-executorch/common/rnexecutorch/utils/FrameTransform.h

@@ -71,9 +71,9 @@ void transformPoints(std::array<P, 4> &points,
       nx = h - y;
       ny = x;
     } else if (orient.orientation == "left") {
-      // CCW: new_x = y, new_y = w - x
-      nx = y;
-      ny = w - x;
+      // CW: new_x = h - y, new_y = x
+      nx = h - y;
+      ny = x;
     } else if (orient.orientation == "right") {
       // CW: new_x = h - y, new_y = x
       nx = h - y;