chore: make creating input shapes prettier

chmjkb · chmjkb · commit e3d63c10e52a · 2025-06-11T10:58:10.000+02:00
diff --git a/packages/react-native-executorch/common/rnexecutorch/models/BaseModel.cpp b/packages/react-native-executorch/common/rnexecutorch/models/BaseModel.cpp
@@ -49,12 +49,8 @@ std::vector<int32_t> BaseModel::getInputShape(std::string method_name,
         std::to_string(static_cast<int>(input_meta.error())));
   }
 
-  std::vector<int32_t> input_shape;
   auto sizes = input_meta->sizes();
-  input_shape.reserve(sizes.size());
-  for (auto size : sizes) {
-    input_shape.push_back(size);
-  }
+  std::vector<int32_t> input_shape(sizes.begin(), sizes.end());
   return input_shape;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,8 @@ std::vector<int32_t> BaseModel::getInputShape(std::string method_name,`
`49`	`49`	`std::to_string(static_cast<int>(input_meta.error())));`
`50`	`50`	`}`
`51`	`51`
`52`		`- std::vector<int32_t> input_shape;`
`53`	`52`	`auto sizes = input_meta->sizes();`
`54`		`- input_shape.reserve(sizes.size());`
`55`		`- for (auto size : sizes) {`
`56`		`- input_shape.push_back(size);`
`57`		`- }`
	`53`	`+ std::vector<int32_t> input_shape(sizes.begin(), sizes.end());`
`58`	`54`	`return input_shape;`
`59`	`55`	`}`
`60`	`56`