Missing const, eslint

Author: mkopcins

packages/react-native-executorch/android/src/main/cpp/ETInstallerModule.cpp

@@ -2,9 +2,10 @@
 
 #include <rnexecutorch/RnExecutorchInstaller.h>
 
+#include "EmulatorDetection.h"
+
 #include <jni.h>
 #include <jsi/jsi.h>
-#include <sys/system_properties.h>
 
 namespace rnexecutorch {
 JavaVM *java_machine;
@@ -65,18 +66,10 @@ void ETInstallerModule::injectJSIBindings() {
     return std::vector<std::byte>(dataBytePtr, dataBytePtr + size);
   };
 
-  auto isEmulator = []() {
-    char fingerprint[PROP_VALUE_MAX] = {0};
-    char hardware[PROP_VALUE_MAX] = {0};
-    __system_property_get("ro.build.fingerprint", fingerprint);
-    __system_property_get("ro.hardware", hardware);
-    std::string fp(fingerprint);
-    std::string hw(hardware);
-    return fp.find("generic") == 0 || hw == "goldfish" || hw == "ranchu";
-  }();
+  auto _isEmulator = isEmulator();
 
   RnExecutorchInstaller::injectJSIBindings(jsiRuntime_, jsCallInvoker_,
-                                           fetchDataByUrl, isEmulator);
+                                           fetchDataByUrl, _isEmulator);
 }
 } // namespace rnexecutorch
 

packages/react-native-executorch/android/src/main/cpp/EmulatorDetection.h

@@ -0,0 +1,27 @@
+#pragma once
+
+#include <sys/system_properties.h>
+#include <string>
+
+namespace rnexecutorch {
+
+inline bool isEmulator() {
+  auto readProp = [](const char *key) -> std::string {
+    const prop_info *pi = __system_property_find(key);
+    if (!pi) return "";
+    std::string result;
+    __system_property_read_callback(
+        pi,
+        [](void *cookie, const char *, const char *value, uint32_t) {
+          *static_cast<std::string *>(cookie) = value;
+        },
+        &result);
+    return result;
+  };
+
+  std::string fp = readProp("ro.build.fingerprint");
+  std::string hw = readProp("ro.hardware");
+  return fp.find("generic") == 0 || hw == "goldfish" || hw == "ranchu";
+}
+
+} // namespace rnexecutorch

packages/react-native-executorch/src/constants/resourceFetcher.ts

@@ -1,2 +1,5 @@
 export const DOWNLOAD_EVENT_ENDPOINT =
   'https://ai.swmansion.com/telemetry/downloads/api/downloads';
+
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+export const LIB_VERSION: string = require('../../package.json').version;

packages/react-native-executorch/src/index.ts

@@ -105,6 +105,7 @@ declare global {
     symbols: string,
     independentCharacters?: boolean
   ) => Promise<any>;
+  // eslint-disable-next-line camelcase
   var __rne_isEmulator: () => boolean;
 }
 // eslint-disable no-var
@@ -126,6 +127,7 @@ if (
   global.loadTextToSpeechKokoro == null ||
   global.loadOCR == null ||
   global.loadVerticalOCR == null ||
+  // eslint-disable-next-line camelcase
   global.__rne_isEmulator == null
 ) {
   if (!ETInstallerNativeModule) {

packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts

@@ -1,6 +1,9 @@
 import { ResourceSource } from '..';
 import { getModelNameForUrl } from '../constants/modelUrls';
-import { DOWNLOAD_EVENT_ENDPOINT } from '../constants/resourceFetcher';
+import {
+  DOWNLOAD_EVENT_ENDPOINT,
+  LIB_VERSION,
+} from '../constants/resourceFetcher';
 
 /**
  * Http status codes
@@ -207,7 +210,6 @@ export namespace ResourceFetcherUtils {
   }
 
   export function isEmulator(): boolean {
-    // eslint-disable-next-line camelcase
     return !!(global as any).__rne_isEmulator;
   }