reafactor: use ScalarType enum instead of magic number in jsi conversions

NorbertKlockiewicz · NorbertKlockiewicz · commit edf20084728e · 2026-03-16T16:49:32.000+01:00
diff --git a/packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h b/packages/react-native-executorch/common/rnexecutorch/host_objects/JsiConversions.h
@@ -578,7 +578,8 @@ getJsiValue(const models::style_transfer::PixelDataResult &result,
   sizesArray.setValueAtIndex(runtime, 2, jsi::Value(4));
   obj.setProperty(runtime, "sizes", sizesArray);
 
-  obj.setProperty(runtime, "scalarType", jsi::Value(0));
+  obj.setProperty(runtime, "scalarType",
+                  jsi::Value(static_cast<int32_t>(ScalarType::Byte)));
 
   return obj;
 }

Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,8 @@ getJsiValue(const models::style_transfer::PixelDataResult &result,`
`578`	`578`	`sizesArray.setValueAtIndex(runtime, 2, jsi::Value(4));`
`579`	`579`	`obj.setProperty(runtime, "sizes", sizesArray);`
`580`	`580`
`581`		`- obj.setProperty(runtime, "scalarType", jsi::Value(0));`
	`581`	`+ obj.setProperty(runtime, "scalarType",`
	`582`	`+ jsi::Value(static_cast<int32_t>(ScalarType::Byte)));`
`582`	`583`
`583`	`584`	`return obj;`
`584`	`585`	`}`