Skip to content

Commit f85f5cd

Browse files
committed
chore: remove redundant loge, call std::move() when forwarding args to FnPtr in ModelHostObject
1 parent 73e6058 commit f85f5cd

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include <ReactCommon/CallInvoker.h>
99

10-
#include <rnexecutorch/Log.h>
1110
#include <rnexecutorch/host_objects/JSTensorViewOut.h>
1211
#include <rnexecutorch/host_objects/JsiConversions.h>
1312
#include <rnexecutorch/jsi/JsiHostObject.h>
@@ -88,8 +87,8 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
8887
std::thread([this, promise,
8988
argsConverted = std::move(argsConverted)]() {
9089
try {
91-
auto result =
92-
std::apply(std::bind_front(FnPtr, model), argsConverted);
90+
auto result = std::apply(std::bind_front(FnPtr, model),
91+
std::move(argsConverted));
9392
// The result is copied. It should either be quickly copiable,
9493
// or passed with a shared_ptr.
9594
callInvoker->invokeAsync([promise,

0 commit comments

Comments
 (0)