Skip to content

chore(android): update binaries so package is compatible with 16KB#1004

Merged
msluszniak merged 1 commit intomainfrom
@nk/update-android-binaries
Mar 24, 2026
Merged

chore(android): update binaries so package is compatible with 16KB#1004
msluszniak merged 1 commit intomainfrom
@nk/update-android-binaries

Conversation

@NorbertKlockiewicz
Copy link
Copy Markdown
Contributor

@NorbertKlockiewicz NorbertKlockiewicz commented Mar 24, 2026

Description

Previously libexecutorch.so was compiled without enabled compatibility with 16 kb page sizes which would make problems for users submitting apps to google play store.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

  • Run llm app on main and check if there is a page with warnings.
  • Run llm app on emulator/phone(pixel 10) which requires 16kb page size, no warning should be shown when app opens.

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak
Copy link
Copy Markdown
Member

So I guess this one: #621 wasn't fixed ;p

@msluszniak msluszniak added platform: android Issues and tasks related to Android chore PRs that are chores labels Mar 24, 2026
@NorbertKlockiewicz
Copy link
Copy Markdown
Contributor Author

So I guess this one: #621 wasn't fixed ;p

It was, however Bartek updated binaries and forgot to add a flag when compiling.

@msluszniak
Copy link
Copy Markdown
Member

It was, however Bartek updated binaries and forgot to add a flag when compiling.

Ok that makes sense 😅

Copy link
Copy Markdown
Member

@msluszniak msluszniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok tested and when running on main, I indeed get warnings:
image

This PR fixes so there are no warning.

@msluszniak msluszniak merged commit f98ddd5 into main Mar 24, 2026
4 checks passed
@msluszniak msluszniak deleted the @nk/update-android-binaries branch March 24, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that are chores platform: android Issues and tasks related to Android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants