fix: Add fixes in Instance Segmentation#1007
Merged
msluszniak merged 6 commits intomainfrom Mar 25, 2026
Merged
Conversation
mkopcins
reviewed
Mar 25, 2026
packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Kopcinski <120639731+mkopcins@users.noreply.github.com>
chmjkb
reviewed
Mar 25, 2026
docs/docs/03-hooks/02-computer-vision/useInstanceSegmentation.md
Outdated
Show resolved
Hide resolved
| * @typeParam C - A {@link InstanceSegmentationModelSources} config specifying which model to load. | ||
| * @param props - Configuration object containing `model` config and optional `preventLoad` flag. | ||
| * @returns An object with model state (`error`, `isReady`, `isGenerating`, `downloadProgress`) and a typed `forward` function. | ||
| * @returns An object with model state (`error`, `isReady`, `isGenerating`, `downloadProgress`), a typed `forward` function, `getAvailableInputSizes` helper, and a `runOnFrame` worklet for VisionCamera integration. |
Collaborator
There was a problem hiding this comment.
im fine with this to unblock this PR but I think this comment doesn't add much value - it's just restating what the code already expresses.
mkopcins
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds spotted fixes to semantic segmentation.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes