refactor: resource fetcher#1023
Merged
Merged
Conversation
chmjkb
marked this pull request as ready for review
March 31, 2026 10:07
This was
linked to
issues
Mar 31, 2026
chmjkb
force-pushed
the
@chmjkb/resource-fetcher-refactor
branch
from
March 31, 2026 10:36
e6a0fc4 to
32a80a2
Compare
Member
|
Please run |
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
reviewed
Mar 31, 2026
mkopcins
requested changes
Mar 31, 2026
msluszniak
reviewed
Apr 20, 2026
mkopcins
approved these changes
Apr 21, 2026
msluszniak
approved these changes
Apr 21, 2026
Member
There was a problem hiding this comment.
I performed detailed testing, code available on branch: https://github.com/msluszniak/react-native-executorch/tree/test/pr-1023-resource-fetcher
Everything worked correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implementations
Note: this PR still uses the legacy FS as the support for background / resumable downloads is WIP.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes