Skip to content

feat: add lfm 2.5 350M as consts#1042

Merged
mkopcins merged 2 commits intomainfrom
@nk/add-lfm-350M
Apr 1, 2026
Merged

feat: add lfm 2.5 350M as consts#1042
mkopcins merged 2 commits intomainfrom
@nk/add-lfm-350M

Conversation

@NorbertKlockiewicz
Copy link
Copy Markdown
Contributor

@NorbertKlockiewicz NorbertKlockiewicz commented Apr 1, 2026 •
edited
Loading

Description

As the name of PR states
HF repo: https://huggingface.co/software-mansion/react-native-executorch-lfm2.5-350M

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak added the feature PRs that implement a new feature label Apr 1, 2026
msluszniak
msluszniak reviewed Apr 1, 2026
View reviewed changes
packages/react-native-executorch/src/constants/modelUrls.ts Outdated
Comment on lines +409 to +412
const LFM2_5_350M_MODEL = `${URL_PREFIX}-lfm2.5-350M/${VERSION_TAG}/xnnpack/lfm2_5_350m_xnnpack_fp16.pte`;
const LFM2_5_350M_QUANTIZED_MODEL = `${URL_PREFIX}-lfm2.5-350M/${VERSION_TAG}/xnnpack/lfm2_5_350m_xnnpack_8w4da.pte`;
const LFM2_5_350M_TOKENIZER = `${URL_PREFIX}-lfm2.5-350M/${VERSION_TAG}/tokenizer.json`;
const LFM2_5_350M_TOKENIZER_CONFIG = `${URL_PREFIX}-lfm2.5-350M/${VERSION_TAG}/tokenizer_config.json`;
Copy link
Copy Markdown
Member

@msluszniak msluszniak Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to release it under current VERSION_TAG aka 0.8.0 instead of 0.9.0? There is no mention about this model in 0.8 documentation.

Copy link
Copy Markdown
Collaborator

@mkopcins mkopcins Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8 is good, we are releasing it with 0.8.1 anyway

Copy link
Copy Markdown
Member

@msluszniak msluszniak Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we needs to update documentation as well :))

Copy link
Copy Markdown
Member

@msluszniak msluszniak Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, we can remove 1.2B and 1.6B from model names, and only list different sizes in separate column. This would also suggest to keep lfm2.5 in both size variants in one hf repo. What do you think?
image

Copy link
Copy Markdown
Collaborator

@mkopcins mkopcins Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah..., not quite, gotta change file structure on hg first

@mkopcins mkopcins merged commit 4cbbfcd into main Apr 1, 2026
5 checks passed
@mkopcins mkopcins deleted the @nk/add-lfm-350M branch April 1, 2026 12:32
mkopcins added a commit that referenced this pull request Apr 1, 2026
@NorbertKlockiewicz @mkopcins
feat: add lfm 2.5 350M as consts (#1042)
57ecd3f 
## Description

As the name of PR states
HF repo:
https://huggingface.co/software-mansion/react-native-executorch-lfm2.5-350M
### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [x] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [ ] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

---------

Co-authored-by: Mateusz Kopciński <mateusz.kopcinski@swmansion.com>
mkopcins added a commit that referenced this pull request Apr 1, 2026
@mkopcins @NorbertKlockiewicz
feat: add lfm 2.5 350M as consts (#1042) (#1045)
6863e5e 
## Description

As the name of PR states
HF repo:

https://huggingface.co/software-mansion/react-native-executorch-lfm2.5-350M
### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [x] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [ ] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

---------

## Description

<!-- Provide a concise and descriptive summary of the changes
implemented in this PR. -->

### Introduces a breaking change?

- [ ] Yes
- [ ] No

### Type of change

- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)

### Tested on

- [ ] iOS
- [ ] Android

### Testing instructions

<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

<!-- Link related issues here using #issue-number -->

### Checklist

- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->

Co-authored-by: Norbert Klockiewicz <Nklockiewicz12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msluszniak msluszniak msluszniak approved these changes

@mkopcins mkopcins Awaiting requested review from mkopcins

Assignees

@NorbertKlockiewicz NorbertKlockiewicz

Labels

feature PRs that implement a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NorbertKlockiewicz @msluszniak @mkopcins