fix: add mutex to VoiceActivityDetection to prevent race between generate() and unload()#1056
Merged
msluszniak merged 2 commits intosoftware-mansion:mainfrom Apr 8, 2026
Merged
Conversation
…rate() and unload() VoiceActivityDetection inherits from BaseModel but lacks the thread-safety that VisionModel already provides. When generate() runs on a worker thread (via ModelHostObject::promiseHostFunction) and unload() is called from the JS thread, BaseModel::unload() destroys module_ mid-inference, causing SIGILL/SIGSEGV crashes. This applies the same pattern used by VisionModel: - Add inference_mutex_ member - Lock in generate() to protect forward() calls - Override unload() to acquire the lock before BaseModel::unload() Fixes software-mansion#1055
Contributor
|
The problem with race condition occurs also in other models that do not inherit from |
Contributor
Author
|
@barhanc unfortunately I would need to deploy that to production to really find out. It is possible if it would be safe but it's complicated as you can understand |
barhanc
approved these changes
Apr 7, 2026
Contributor
barhanc
left a comment
barhanc
left a comment
There was a problem hiding this comment.
We will apply fixes on per-model basis mirroring what you did for VAD. Thanks for submitting this fix.
...tive-executorch/common/rnexecutorch/models/voice_activity_detection/VoiceActivityDetection.h
Outdated
Show resolved
Hide resolved
…ice_activity_detection/VoiceActivityDetection.h
msluszniak
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add thread-safety to
VoiceActivityDetectionusing the same mutex pattern already established byVisionModel.Without this,
BaseModel::unload()can destroymodule_on the JS thread whilegenerate()is still callingforward()on a worker thread, causingSIGILL/SIGSEGVcrashes.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Use
useVAD({ model: FSMN_VAD })with continuous audio input and trigger rapid mount/unmount cycles. Confirm no crashes or deadlocks.Related issues
Fixes #1055