feat: voice-activity streaming mode & inner-vad for speech-to-text module#1160
Open
IgorSwat wants to merge 10 commits into
Open
feat: voice-activity streaming mode & inner-vad for speech-to-text module#1160IgorSwat wants to merge 10 commits into
IgorSwat wants to merge 10 commits into
Conversation
694fe4f to
1c2411e
Compare
chmjkb
requested changes
May 20, 2026
msluszniak
reviewed
May 20, 2026
Comment on lines
+24
to
+26
| inline constexpr size_t kMinSpeechDuration = 25; // 250 ms | ||
| inline constexpr size_t kMinSilenceDuration = 10; // 100 ms | ||
| inline constexpr size_t kSpeechPad = 3; // 30 ms |
Member
There was a problem hiding this comment.
Why these are in 10s of ms while other constants above are in miliseconds?
Contributor
Author
There was a problem hiding this comment.
All the constants in this file are in 10s of ms.
Member
There was a problem hiding this comment.
Then why these are named kWindowSizeMs and kHopLengthMs, this ms suffix almost screams to me: "This value is in milliseconds". If not, then I would be very surprised ;p
02113ff to
6bba141
Compare
chmjkb
requested changes
May 21, 2026
1c2411e to
0ea858d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes focused on voice-activity-detection module and it's utilization within the library:
VoiceActivityDetectionScreenand changes the behavior ofSpeechToTextScreen, adding a toggle to switch the VAD submodule for STT on/off.Introduces a breaking change?
Type of change
Tested on
Testing instructions
VoiceActivityDetectionScreenwithin theSpeechdemo app.SpeechToTextScreenwithin theSpeechdemo app, with VAD toggle on.Screenshots
Related issues
#1118
Checklist
Additional notes