chore: Merge llm-tool-calling example with llm example#247
Merged
pweglik merged 12 commits intov0.4.0-rc1from May 11, 2025
Merged
chore: Merge llm-tool-calling example with llm example#247pweglik merged 12 commits intov0.4.0-rc1from
pweglik merged 12 commits intov0.4.0-rc1from
Conversation
NorbertKlockiewicz
approved these changes
May 7, 2025
pweglik
force-pushed
the
@pw/chore/merge-example-apps
branch
2 times, most recently
from
464f936 to
bb621a3
Compare
pweglik
force-pushed
the
@pw/chore/merge-example-apps
branch
from
bb621a3 to
9a6af53
Compare
pweglik
force-pushed
the
@pw/chore/merge-example-apps
branch
from
9a6af53 to
abbad73
Compare
chmjkb
reviewed
May 9, 2025
Collaborator
chmjkb
left a comment
chmjkb
left a comment
There was a problem hiding this comment.
One note here: Can we refactor LLMToolCallingScreen and LLMScreen? I think the code repetition is pretty big and could be reduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved code from more flashy seprate example into tab of llm example. Simpler in maintanace
Tested on
Related issues
#236
Checklist