feat: port image segmentation native code to C++#313
Merged
JakubGonera merged 9 commits into@jakubgonera/cppfrom May 27, 2025
Merged
feat: port image segmentation native code to C++#313JakubGonera merged 9 commits into@jakubgonera/cppfrom
JakubGonera merged 9 commits into@jakubgonera/cppfrom
Conversation
JakubGonera
force-pushed
the
@jakubgonera/segmentation_cherry_pick
branch
2 times, most recently
from
353d8e6 to
c2064bb
Compare
JakubGonera
force-pushed
the
@jakubgonera/segmentation_cherry_pick
branch
from
d4477bd to
5363df4
Compare
msluszniak
reviewed
May 26, 2025
msluszniak
reviewed
May 26, 2025
msluszniak
reviewed
May 26, 2025
msluszniak
reviewed
May 26, 2025
| std::shared_ptr<react::CallInvoker> callInvoker) | ||
| : BaseModel(modelSource, callInvoker) { | ||
|
|
||
| std::vector<int32_t> modelInputShape = getInputShape()[0]; |
Member
There was a problem hiding this comment.
assert on at least two elements in modelInputShape
msluszniak
reviewed
May 26, 2025
| : BaseModel(modelSource, runtime) { | ||
| std::shared_ptr<react::CallInvoker> callInvoker) | ||
| : BaseModel(modelSource, callInvoker) { | ||
| std::vector<int32_t> modelInputShape = getInputShape()[0]; |
Member
There was a problem hiding this comment.
assert on modelInputShape at least 2
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
mkopcins
approved these changes
May 26, 2025
JakubGonera
added a commit
that referenced
this pull request
May 28, 2025
Port image segmentation native code to C++. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) - [x] iOS - [x] Android - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings --------- Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port image segmentation native code to C++.
Type of change
Tested on
Related issues
#256 #255
Checklist