Skip to content

Refactor Executorch bindings#379

Closed
msluszniak wants to merge 4 commits intomainfrom
@ms/refactor-executorch-bindings
Closed

Refactor Executorch bindings#379
msluszniak wants to merge 4 commits intomainfrom
@ms/refactor-executorch-bindings

Conversation

@msluszniak
Copy link
Copy Markdown
Member

Description

Refactor Executorch bindings to pass to ExecutorchModule.forward Tensor instead of separate ETInput and shape.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

Use ExecutorchModule.forward with new workflow.

Screenshots

Not applicable

Related issues

#209

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak self-assigned this Jun 7, 2025
Comment thread docs/docs/typescript-api/ExecutorchModule.md Outdated
@msluszniak msluszniak linked an issue Jun 7, 2025 that may be closed by this pull request
@chmjkb
Copy link
Copy Markdown
Collaborator

chmjkb commented Jun 9, 2025

Hey, thanks for submitting this PR! I need to close it since we're completely rewriting this API as part of our broader C++ migration effort. You can track the progress in #345. We may incorporate some of your documentation changes though! 😄

@chmjkb chmjkb closed this Jun 9, 2025
@msluszniak msluszniak deleted the @ms/refactor-executorch-bindings branch October 2, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants