Refactor model URL constants#382
Closed
msluszniak wants to merge 1 commit intomainfrom
Closed
Conversation
chmjkb
approved these changes
Jun 24, 2025
Collaborator
chmjkb
left a comment
There was a problem hiding this comment.
review the conflict and we can merge!
Member
Author
|
I'm thinking about adding model name before each block e.g.: const LLAMA3_2_MODEL_NAME = 'llama-3.2';
export const LLAMA3_2_3B = `${BASE_URL_PREFIX}-${LLAMA3_2_MODEL_NAME}/${VERSION_TAG}/llama-3.2-3B/original/llama3_2_3B_bf16.pte`;
export const LLAMA3_2_3B_QLORA = `${BASE_URL_PREFIX}-${LLAMA3_2_MODEL_NAME}/${VERSION_TAG}/llama-3.2-3B/QLoRA/llama3_2-3B_qat_lora.pte`;and moving the problem with naming inconsistencies into separate issue. What do you think @chmjkb? |
Collaborator
I think its fine if you change that too, and keep the naming stuff in a separate one. |
This was referenced Jun 30, 2025
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors URLs for models. This also exposed great inconsistencies in naming across hugging face repository:
llama3_2-3B_qat_lora.ptethere is-between name and number of parameters, while for the rest is_.WHISPER_TINY_DECODERenis concatenated in the first part of URL with.and not with-as in the rest of examples.allinefficientnet_v2_s_coreml_alland only for that model.-and the model name as well -phi-4-miniandphi-4-mini_bf16.ptewhile in others there is-and_e.g.qwen-2.5andqwen2_5_3b_8da4w.pte.xnnpack_whisper_encoder.pteand some on the end or almost end:style_transfer_udnie_xnnpack.pte.ssdlite320-mobilenet-v3-largev3 here is concatenated with-but in model name not:ssdlite320-mobilenetv3-large.pte.smolLm-2-135MandsmolLm2_135M_bf16.pteand for some not:qwen-2.5-1.5Bandqwen2_5_0_5b_8da4w.pte.And there are even more, but you will spot them while correcting rest. I think that there is need to make this unified. And then I will be able to refactor this even more.
Type of change
Tested on
Testing instructions
No apply
Screenshots
No apply
Related issues
No apply
Checklist
Additional notes