@mlodyjesienin/example app UI by mlodyjesienin · Pull Request #386 · software-mansion/react-native-executorch

mlodyjesienin · 2025-06-10T12:10:05Z

Description

Migrated example apps (llm, computervision) to expo router navigation.
Added drawer navigation and menu for better UX.
Fixed small issues regarding keyboard padding.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Tested on

iOS
Android

Related issues

Issue #224

Checklist

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas, (not necessary)
I have updated the documentation accordingly, (not necessary)
My changes generate no new warnings

msluszniak · 2025-06-10T15:59:59Z

Calling yarn in example apps generates now new warnings:

➤ YN0002: │ computer-vision@workspace:apps/computer-vision doesn't provide @react-navigation/native (p65dbd), requested by @react-navigation/drawer.
➤ YN0002: │ llm@workspace:apps/llm doesn't provide @react-navigation/native (pe0aa0), requested by @react-navigation/drawer.

msluszniak · 2025-06-10T16:18:45Z

Could you also handle this one: #349 in this PR and disable voice chat on emulator in llm examples?

msluszniak · 2025-06-10T16:40:14Z

This seems to be a bit of redudancy:

msluszniak · 2025-06-10T16:41:58Z

~~If I'm not wrong, currently tool calling supports only calls to Google Calendar, not the regular calendar on device. So make it clear and add Google Calendar instead of calendar.~~
My bad, ignore this comment. This not work for me on emulator, so I'll create separate issue about this.

msluszniak · 2025-06-10T16:43:28Z

I guess that the icon in the chat presents a lama because the model was previously LLaMa. Now it's Qwen, so maybe think of changing this one.

msluszniak · 2025-06-10T16:45:25Z

I think that in llm examples it will be better to use simple stack navigation with back arrow to the main screen instead of drawer navigation.

msluszniak · 2025-06-10T16:57:11Z

Could you disable the button with camera on emulator for all examples in apps/computer-vision?

PS. change order of words to Top 10 Results, sounds better imho.

msluszniak · 2025-06-10T17:11:42Z

I don't understand what should present the Object Detection example in apps/computer-vision. Does it even work?

msluszniak · 2025-06-10T17:13:34Z

The fact that OCR and Vertical OCR on the list below are not two consecutive elements is unnatural for me. Maybe consider changing the name to OCR Vertical to preserve alphabetical order and force the intuitive order.

msluszniak · 2025-06-10T17:39:44Z

Maybe it is worth adding upload from device option for speech to text example?

msluszniak · 2025-06-10T17:49:38Z

There is no way now to clear automatically added sentences and user defined sentences. I think it will be nice to add such option.

msluszniak · 2025-06-10T17:55:16Z

Deactivate Find Similar when no input provided, and communicate more explicitly in this example that you need to provide sentence and use Find Similar on that particular sentence. I thought, that I should enter all context sentences by Add to list and then clicking Find Similar will generate me some text embeddings similar to the context sentences.

msluszniak · 2025-06-10T18:01:24Z

In computer-vision package.json there is "react-native-executorch": "0.4.2", while other examples use react-native-executorch from monorepo, maybe change this one.

NorbertKlockiewicz · 2025-06-11T06:39:29Z

    "icon": "./assets/icons/icon.png",
    "userInterfaceStyle": "light",
    "newArchEnabled": true,
+    "scheme": "your-app-scheme",


I think it would be better to set scheme to "rne-computer-vision"

Do the same for other apps

NorbertKlockiewicz · 2025-06-11T06:44:43Z

    "react": "19.0.0",
    "react-native": "0.79.2",
-    "react-native-executorch": "workspace:*",
+    "react-native-executorch": "0.4.2",


Suggested change

"react-native-executorch": "0.4.2",

"react-native-executorch": "workspace:*",

NorbertKlockiewicz · 2025-06-11T06:45:34Z

    "orientation": "portrait",
    "icon": "./assets/icons/icon.png",
    "userInterfaceStyle": "light",
+    "scheme": "your-app-scheme",


Same as in computer vision rne-llm

NorbertKlockiewicz · 2025-06-11T06:48:42Z

  });
  const speechToText = useSpeechToText({
-    modelName: 'moonshine',
+    modelName: 'whisper',


why this change? I think w should stay with moonshine as default

NorbertKlockiewicz · 2025-06-13T07:38:44Z

+        <action android:name="android.intent.action.VIEW"/>
+        <category android:name="android.intent.category.DEFAULT"/>
+        <category android:name="android.intent.category.BROWSABLE"/>
+        <data android:scheme="your-app-scheme"/>


You need to run npx expo prebuild for a changes from app.json to be applied, but when doing that don't forget to open ios project in xcode and add increased memory capability

NorbertKlockiewicz · 2025-06-13T07:41:22Z

+  return context;
+}
+
+import { ReactNode } from 'react';


Move the import to the top of this file

NorbertKlockiewicz · 2025-06-13T07:50:55Z

I've tested it and works fine. Please apply changes requested i my two comments, fix the conflicts and you can merge.

…voice_chat

…ating

…ddings

msluszniak · 2025-06-16T11:56:48Z

Speech to text example still contains in package.json "react-native-wheel-scrollview-picker": "^2.0.6", you can remove it ;)

#401) …hen they go out of focus by introducing wrapers. ## Description ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions  ### Screenshots  ### Related issues  ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes  --------- Co-authored-by: mlodyjesienin <filipzielinski377@gmail.com>

msluszniak · 2025-06-17T14:02:27Z

Are you able to run successfully for some url Speech to text example on iOS emulator? I'm receiving constant crashes @mlodyjesienin @NorbertKlockiewicz. If no, I'll create a separate issue to not block this one

NorbertKlockiewicz · 2025-06-18T07:47:57Z

Are you able to run successfully for some url Speech to text example on iOS emulator? I'm receiving constant crashes @mlodyjesienin @NorbertKlockiewicz. If no, I'll create a separate issue to not block this one

Same problem at my side, tested it with audio that worked some time ago. However it's not in scope of this PR so I will be thankful if you can add a separate issue.

msluszniak · 2025-06-18T09:26:18Z

Done: #409
The very basic triage directs to audio-api

NorbertKlockiewicz · 2025-06-18T09:27:05Z

+import { BottomBar } from '../../components/BottomBar';
+import React, { useContext, useEffect, useState } from 'react';
+import { GeneratingContext } from '../../context';
+import ScreenWrapper from '../../screenWrapper';


I think the name of the screenWrapper file should start from large letter as it's a component

NorbertKlockiewicz · 2025-06-18T09:31:43Z

+import { useIsFocused } from '@react-navigation/native';
+import { GeneratingContext } from '../../context';
+
+export default function LLMScreenWrapper() {


Maybe let's move this wrapper to separate file like in computer-vision example

It's not used anywhere, remove it

msluszniak · 2025-06-18T18:21:42Z

A really good job on this one 👏🏻

## Description Migrated example apps (llm, computervision) to expo router navigation. Added drawer navigation and menu for better UX. Fixed small issues regarding keyboard padding. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) ### Tested on - [x] iOS - [x] Android ### Related issues Issue #224 ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas, (not necessary) - [ ] I have updated the documentation accordingly, (not necessary) - [ ] My changes generate no new warnings --------- Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>

mlodyjesienin requested a review from NorbertKlockiewicz June 10, 2025 12:10

msluszniak reviewed Jun 10, 2025

View reviewed changes

Comment thread apps/computer-vision/app/_layout.tsx Outdated

msluszniak reviewed Jun 10, 2025

View reviewed changes

Comment thread apps/llm/package.json Outdated

msluszniak linked an issue Jun 10, 2025 that may be closed by this pull request

Find alternative for scroll picker with better UX for example apps. #224

Closed

msluszniak assigned mlodyjesienin Jun 10, 2025

NorbertKlockiewicz requested changes Jun 11, 2025

View reviewed changes

mlodyjesienin marked this pull request as draft June 12, 2025 11:40

NorbertKlockiewicz approved these changes Jun 13, 2025

View reviewed changes

mlodyjesienin added 8 commits June 16, 2025 10:56

feat: use expo router and add drawer to enhance ux

8fa203a

feat: expo routers, drawer navigation, small fixes

89dd2c5

fix: deps for apps/computer-vision

09b523a

fix: scheme and typos, computer-vision

cfb4fe9

feat: disable camera on emulator for computer-vision

ec4d27f

fix: Change order (OCR Vertical) in computer-vision

e261b9c

fix: dependecies and scheme for app/llm

59fa5d7

fix: disable voice chat on emulator and change to moonshine apps/llm/…

660020d

…voice_chat

mlodyjesienin added 5 commits June 16, 2025 10:58

fix: remove redundant llm tool calling information

55e988f

work in progress - fix:switching between screens while model is gener…

62bbdad

…ating

feat: clear list button and disabled buttons logic for apps/text-embe…

4a0e7c4

…ddings

fix: proper your-scheme value in android/ files

9fad500

refactor: get rid of not used LlmContext

fec4dc1

mlodyjesienin force-pushed the @mlodyjesienin/example-app-ui branch from 75ff9ff to fec4dc1 Compare June 16, 2025 09:08

mlodyjesienin added 2 commits June 16, 2025 12:03

fix: after rebase main build issues

7eeebce

fix: after rebase main build issues, increase memory limit ios

c503ab9

mlodyjesienin and others added 4 commits June 16, 2025 15:40

fix: fully removed wheel-scroll-picker from the deps

9bc6d65

Merge branch '@mlodyjesienin/example-app-ui' remote with local

2741dcd

fix: truly disable camera in computer-vision on emulator

aa7a6b1

mlodyjesienin marked this pull request as ready for review June 17, 2025 12:16

mlodyjesienin requested a review from NorbertKlockiewicz June 17, 2025 12:16

mlodyjesienin linked an issue Jun 18, 2025 that may be closed by this pull request

Disable example with Speech to text in apps/llm on emulator #349

Closed

NorbertKlockiewicz requested changes Jun 18, 2025

View reviewed changes

mlodyjesienin added 2 commits June 18, 2025 12:54

refactor: rename ScreenWrapper to Pascal Case

688ea55

fix: case sensitivity issues with renaming ScreenWrapper

7b9433f

NorbertKlockiewicz self-requested a review June 18, 2025 12:07

NorbertKlockiewicz approved these changes Jun 18, 2025

View reviewed changes

mlodyjesienin merged commit 573edd1 into main Jun 18, 2025
4 of 5 checks passed

mlodyjesienin deleted the @mlodyjesienin/example-app-ui branch June 18, 2025 12:09

	"react-native-executorch": "0.4.2",
	"react-native-executorch": "workspace:*",

Conversation

mlodyjesienin commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Tested on

Related issues

Checklist

Uh oh!

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025

Uh oh!

msluszniak commented Jun 10, 2025

Uh oh!

msluszniak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NorbertKlockiewicz commented Jun 13, 2025

Uh oh!

msluszniak commented Jun 16, 2025

Uh oh!

msluszniak commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NorbertKlockiewicz commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msluszniak commented Jun 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

msluszniak commented Jun 18, 2025

Uh oh!

mlodyjesienin commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 10, 2025 •

edited

Loading

msluszniak commented Jun 17, 2025 •

edited

Loading

NorbertKlockiewicz commented Jun 18, 2025 •

edited

Loading