Conversation
…fferent requires in development mode
pweglik
changed the title
mkopcins
approved these changes
Jun 13, 2025
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
… different requires in development mode (#396) ## Description When loading two models using require the 2nd would overwrite the 1st one, cause this function produced the same name for them. It worked for remote URLs that were different in path part (the one divided by slashes), but locally loaded files only differ by GET params, that were cut off by split('?')[0]. This fixes it. It might be considered breaking change in a sense it may change names of models in the current app, so models will redownload ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [x] Android ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When loading two models using require the 2nd would overwrite the 1st one, cause this function produced the same name for them. It worked for remote URLs that were different in path part (the one divided by slashes), but locally loaded files only differ by GET params, that were cut off by split('?')[0]. This fixes it.
It might be considered breaking change in a sense it may change names of models in the current app, so models will redownload
Type of change
Tested on
Checklist