Conversation
pweglik
commented
Jun 13, 2025
pweglik
commented
Jun 13, 2025
JakubGonera
reviewed
Jun 13, 2025
msluszniak
reviewed
Jun 13, 2025
msluszniak
reviewed
Jun 13, 2025
pweglik
force-pushed
the
@pw/image-embeddings
branch
from
69456e3 to
2157bec
Compare
mkopcins
reviewed
Jun 16, 2025
pweglik
force-pushed
the
@pw/image-embeddings
branch
from
aacc266 to
4cbe3a2
Compare
msluszniak
reviewed
Jun 24, 2025
msluszniak
reviewed
Jun 24, 2025
mkopcins
requested changes
Jun 24, 2025
| **`modelSource`** | ||
| A string that specifies the location of the model binary. For more information, take a look at [loading models](../fundamentals/loading-models.md) page. | ||
|
|
||
| **`preventLoad?`** - Boolean that can prevent automatic model loading (and downloading the data if you load it for the first time) after running the hook. |
Collaborator
There was a problem hiding this comment.
Suggested change
| **`preventLoad?`** - Boolean that can prevent automatic model loading (and downloading the data if you load it for the first time) after running the hook. | |
| **`preventLoad?`** - Boolean that can prevent automatic model loading (and downloading the model if you load it for the first time) after running the hook. |
Contributor
Author
There was a problem hiding this comment.
i copied it over from other pages. I'd leave it like that - I think we actually mean it. Model loading (which mean downloading a lot of data)
Collaborator
There was a problem hiding this comment.
yes, but it might be misleading what data we mean
|
|
||
| // Running the model | ||
| const embedding = await ImageEmbeddingsModule.forward( | ||
| 'https://url-to-image.jpg' |
Collaborator
There was a problem hiding this comment.
in general i don't like things that would compile without error here, I saw too many peoples just copying it and then being upset about the url not working. Just a thought tho
Contributor
Author
There was a problem hiding this comment.
That's good point, but on the other hand it shows that any existing URL works - '...' doesn't transfer this knowledge
Collaborator
There was a problem hiding this comment.
I was thinking something more like ... which just wouldn't run at all and point to this as an error in code syntax itself
|
|
||
| ## Loading the model | ||
|
|
||
| To load the model, use the `load` method. It accepts the `modelSource` which is a string that specifies the location of the model binary. For more information, take a look at [loading models](../fundamentals/loading-models.md) page. This method returns a promise, which can resolve to an error or void. |
Collaborator
There was a problem hiding this comment.
Suggested change
| To load the model, use the `load` method. It accepts the `modelSource` which is a string that specifies the location of the model binary. For more information, take a look at [loading models](../fundamentals/loading-models.md) page. This method returns a promise, which can resolve to an error or void. | |
| To load the model, use the `load` method. It accepts `modelSource` which is a string that specifies the location of the model binary. For more information, take a look at [loading models](../fundamentals/loading-models.md) page. This method returns a promise which can resolve to an error or void. |
Contributor
Author
There was a problem hiding this comment.
Again - it should be fixed in several pages. I think we should utilize .mdx more
mkopcins
approved these changes
Jun 25, 2025
This was referenced Jun 30, 2025
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
## Description Introducing image embeddings feature. TODO: benchmarks Everything else is good to review. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Related issues #353 ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing image embeddings feature.
TODO:
benchmarks
Everything else is good to review.
Type of change
Tested on
Related issues
#353
Checklist
Additional notes