Skip to content

fix: model loading and deleting logic inside useLLM hook#404

Merged
jakmro merged 1 commit intomainfrom
@jakmro/useLLM-fixes
Jun 17, 2025
Merged

fix: model loading and deleting logic inside useLLM hook#404
jakmro merged 1 commit intomainfrom
@jakmro/useLLM-fixes

Conversation

@jakmro
Copy link
Copy Markdown
Contributor

@jakmro jakmro commented Jun 17, 2025

Description

Move try/catch inside async function, delete model only when preventLoad is set to false.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro requested a review from pweglik June 17, 2025 09:59
@jakmro jakmro merged commit 005dbf8 into main Jun 17, 2025
2 checks passed
@jakmro jakmro deleted the @jakmro/useLLM-fixes branch June 17, 2025 11:05
mkopcins pushed a commit that referenced this pull request Oct 15, 2025
## Description
Move try/catch inside async function, delete model only when preventLoad
is set to false.

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on

- [x] iOS
- [ ] Android

### Checklist

- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have updated the documentation accordingly
- [x] My changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants