Delete unused objective-c++ files#631
Delete unused objective-c++ files#631msluszniak merged 3 commits intosoftware-mansion:mainfrom msluszniak:@ms/remove-unused-files
Conversation
|
@chmjkb Can we also delete objective-c++ installers, namely: https://github.com/software-mansion/react-native-executorch/blob/main/packages/react-native-executorch/ios/RnExecutorch/ETInstaller.mm and header for it? |
|
From CI it seems that |
This one we're actually using
I'll check it out |
|
@msluszniak can you try to remove the cocoapods caching part from build-ios workflow file. I believe it's causing the problems with CI fails. |
The install cocoapods action still hit the cache as it has if that checks if the |
|
@NorbertKlockiewicz should these cache things from ios workflow be deleted permanently? |
Yes, we already cache native folders and installing the cocoapods dependencies doesn't take that much time. |
## Description As in the title, utils defined in the `ios/RnExecutorch/utils` are not longer used so they can be deleted. ### Introduces a breaking change? - [ ] Yes - [X] No ### Type of change - [ ] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [x] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->

Description
As in the title, utils defined in the
ios/RnExecutorch/utilsare not longer used so they can be deleted.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes