bug: Allow passing options to useSpeechToText model.stream()#648
Merged
bug: Allow passing options to useSpeechToText model.stream()#648
Conversation
Collaborator
Author
|
@michaldudek FYI: Hi, had to close your PR and reopen with cherry-picked commits |
jakmro
approved these changes
Oct 15, 2025
msluszniak
changed the title
mkopcins
changed the title
mkopcins
changed the title
mkopcins
added a commit
that referenced
this pull request
Oct 15, 2025
When using multilingual transcription model (e.g. `WHISPER_TINY`) language is expected, but there's no way to pass it to the `model.stream()` method: Encountered error: ``` [Error: Model is multilingual, provide a language] ``` IDE: <img width="578" height="220" alt="Screenshot 2025-10-14 at 22 21 32" src="https://github.com/user-attachments/assets/9f9ff6d1-ea4a-4571-8a64-4aed7a4200a5" /> It looks like `SpeechToTextModule.stream()` does accept options with language, but the wrapper function in `useSpeechToText()` does not, making it impossible to use the multilingual model. - [ ] Yes - [x] No - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) - [x] iOS - [ ] Android <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> <!-- Add screenshots here, if applicable --> <!-- Link related issues here using #issue-number --> - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Michał Pałys-Dudek <michal@pnd.io>
msluszniak
pushed a commit
that referenced
this pull request
Oct 16, 2025
## Description When using multilingual transcription model (e.g. `WHISPER_TINY`) language is expected, but there's no way to pass it to the `model.stream()` method: Encountered error: ``` [Error: Model is multilingual, provide a language] ``` IDE: <img width="578" height="220" alt="Screenshot 2025-10-14 at 22 21 32" src="https://github.com/user-attachments/assets/9f9ff6d1-ea4a-4571-8a64-4aed7a4200a5" /> It looks like `SpeechToTextModule.stream()` does accept options with language, but the wrapper function in `useSpeechToText()` does not, making it impossible to use the multilingual model. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Michał Pałys-Dudek <michal@pnd.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using multilingual transcription model (e.g.
WHISPER_TINY) language is expected, but there's no way to pass it to themodel.stream()method:Encountered error:
IDE:
It looks like
SpeechToTextModule.stream()does accept options with language, but the wrapper function inuseSpeechToText()does not, making it impossible to use the multilingual model.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes