bug: fix to corrupted utf-8 encoding for special characters in transcription#652
Merged
bug: fix to corrupted utf-8 encoding for special characters in transcription#652
Conversation
msluszniak
reviewed
Oct 17, 2025
msluszniak
requested changes
Oct 17, 2025
Member
msluszniak
left a comment
msluszniak
left a comment
There was a problem hiding this comment.
JS code is not formatted, also two NITs above, and I think it will be ready to ship it
msluszniak
reviewed
Oct 17, 2025
NorbertKlockiewicz
approved these changes
Oct 17, 2025
mkopcins
force-pushed
the
@mkopcins/s2t-special-char-fix
branch
3 times, most recently
from
9712cd1 to
46f436a
Compare
mkopcins
force-pushed
the
@mkopcins/s2t-special-char-fix
branch
from
46f436a to
5c5d168
Compare
mkopcins
added a commit
that referenced
this pull request
Oct 17, 2025
…ription (#652) ## Description Fix for issue #651. The problem was the serialization of cpp string into jsi::Value and then back to a string, causing invalid characters and bytes. Now cpp returns array of bytes and the decoding is done on the JS side. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #651. The problem was the serialization of cpp string into jsi::Value and then back to a string, causing invalid characters and bytes. Now cpp returns array of bytes and the decoding is done on the JS side.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes