chore: Add [[nodiscard]] attribute to native functions#660
Merged
msluszniak merged 5 commits intomainfrom Jan 16, 2026
Merged
Conversation
msluszniak
changed the title
[[nodiscard]] attribute to native functions
msluszniak
approved these changes
Oct 23, 2025
Collaborator
|
Can you resolve conflicts before I review this? cc @msluszniak |
Member
|
@chmjkb sure thing, the conflicts comes from today's PRs ;) |
Member
|
@chmjkb conflicts resolved |
## Description Hotfix for compilation error. Readied +operator ### Introduces a breaking change? - [x] Yes - [ ] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [x] iOS - [x] Android
chmjkb
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As in the title, add
[[nodiscard]]attribute to exported functions in native implementation.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Check if all demo apps work the same as previously
Screenshots
Related issues
Closes #448
Checklist
Additional notes