Skip to content

fix: ask for permissions even if denied at some point (tool calling example app)#834

Merged
msluszniak merged 3 commits intomainfrom
@ml/ask-for-permissions-tool-calling-example
Feb 25, 2026
Merged

fix: ask for permissions even if denied at some point (tool calling example app)#834
msluszniak merged 3 commits intomainfrom
@ml/ask-for-permissions-tool-calling-example

Conversation

@mateuszlampert
Copy link
Copy Markdown
Contributor

Description

This PR fixes permissions management for tool calling example app, so user will be always prompted for missing permissions even if denied them at some point. This PR:

  • adds Alert that asks for permissions again
  • adds banners (with links) that show missing permissions

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Run LLM Tool Calling example app

Screenshots

Related issues

#774

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@mateuszlampert mateuszlampert marked this pull request as ready for review February 24, 2026 11:52
@mateuszlampert mateuszlampert linked an issue Feb 24, 2026 that may be closed by this pull request
@mateuszlampert mateuszlampert changed the title fix: ask for permissions even if denied at some point fix: ask for permissions even if denied at some point (tool calling example app) Feb 24, 2026
@msluszniak msluszniak added the bug fix PRs that are fixing bugs label Feb 24, 2026
@msluszniak msluszniak merged commit 949985e into main Feb 25, 2026
4 checks passed
@msluszniak msluszniak deleted the @ml/ask-for-permissions-tool-calling-example branch February 25, 2026 08:48
barhanc pushed a commit that referenced this pull request Feb 25, 2026
…xample app) (#834)

## Description

This PR fixes permissions management for tool calling example app, so
user will be always prompted for missing permissions even if denied them
at some point. This PR:
- adds `Alert` that asks for permissions again
- adds banners (with links) that show missing permissions

### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [x] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [x] Android

### Testing instructions

Run LLM Tool Calling example app

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

#774 

### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
barhanc pushed a commit that referenced this pull request Feb 25, 2026
…xample app) (#834)

## Description

This PR fixes permissions management for tool calling example app, so
user will be always prompted for missing permissions even if denied them
at some point. This PR:
- adds `Alert` that asks for permissions again
- adds banners (with links) that show missing permissions

### Introduces a breaking change?

- [ ] Yes
- [x] No

### Type of change

- [x] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Documentation update (improves or adds clarity to existing
documentation)
- [ ] Other (chores, tests, code style improvements etc.)

### Tested on

- [x] iOS
- [x] Android

### Testing instructions

Run LLM Tool Calling example app

### Screenshots

<!-- Add screenshots here, if applicable -->

### Related issues

#774 

### Checklist

- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings

### Additional notes

<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix PRs that are fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with insufficient permissions in tool calling example

2 participants