fix: Make package.json accept newer versions of libs, e.g. Expo#886
fix: Make package.json accept newer versions of libs, e.g. Expo#886msluszniak merged 4 commits intomainfrom
Conversation
|
Unfortunately, it seems that Expo 55.0.3 does not included fix with newer RNScreens version, which blocks us from bumping expo in our example apps look here: software-mansion/react-native-screens#3682. So we need to wait for this until this will be merged. |
chmjkb
left a comment
There was a problem hiding this comment.
lgtm, but we need to do the same thing on the 0.7 release branch and release a patched version so 0.7 supports Expo 55
|
also TBH i don't understand why we're not just saving the image to FS on the native side, and returning the URI but that's not the point of this PR, am i missing something here? |
You mean specifically TextToImage TS part which was modified in this PR? |
Yeah, style transfer does this: It would make sense to me that TTI does this too (and we wouldnt have to do the png stuff). This isn't really related to changes made in this PR, but a thought of mine |
|
Ok, right style transfer is ok, but typedocs are incorrect: /**
* Executes the model's forward pass, where `imageSource` can be a fetchable resource or a Base64-encoded string.
*
* @param imageSource - The image source to be processed.
* @returns The stylized image as a Base64-encoded string. THIS IS INCORRECT
*/
async forward(imageSource: string): Promise<string> {
if (this.nativeModule == null)
throw new RnExecutorchError(
RnExecutorchErrorCode.ModuleNotLoaded,
'The model is currently not loaded. Please load the model before calling forward().'
);
return await this.nativeModule.generate(imageSource);
} |
This PR fixes package.json in both expo and bare resource fetchers. - [ ] Yes - [x] No - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) - [x] iOS - [ ] Android * Run minimal app that utilizes this version of our library with expo 55 (pack react native executorch and expo resource fetchers into tgz and install in template app) and check if everything works correctly. * Run text to image example as this PR introduces changes in this package and check if everything works ok. <!-- Add screenshots here, if applicable --> Closes #882 - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [ ] My changes generate no new warnings <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
Description
This PR fixes package.json in both expo and bare resource fetchers.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Closes #882
Checklist
Additional notes