Skip to content

fix: fix unload in LLM and ModelHostObject to properly free LLM memory #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msluszniak merged 3 commits into from
Mar 12, 2026
Merged

fix: fix unload in LLM and ModelHostObject to properly free LLM memory #954

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcd7a6e
fix: fix unload in LLM and ModelHostObject to properly free memory
barhanc Mar 10, 2026
3fccdbc
fix: remove unnecessary blank line in LLMController
barhanc Mar 11, 2026
b7b0d74
Update packages/react-native-executorch/common/rnexecutorch/models/ll…
barhanc Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native-executorch/common/rnexecutorch/host_objects/ModelHostObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@ template <typename Model> class ModelHostObject : public JsiHostObject {
JSI_HOST_FUNCTION(unload) {
try {
model->unload();
thisValue.asObject(runtime).setExternalMemoryPressure(runtime, 0);
} catch (const RnExecutorchError &e) {
jsi::Object errorData(runtime);
errorData.setProperty(runtime, "code", e.getNumericCode());
Expand Down
5 changes: 4 additions & 1 deletion packages/react-native-executorch/common/rnexecutorch/models/llm/LLM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@
return runner_->get_max_context_length();
}

void LLM::unload() noexcept { runner_.reset(nullptr); }
void LLM::unload() noexcept {
runner.reset(nullptr);

Check failure on line 259 in packages/react-native-executorch/common/rnexecutorch/models/llm/LLM.cpp

View workflow job for this annotation

GitHub Actions / build 

use of undeclared identifier 'runner'; did you mean 'runner_'?
Comment thread
barhanc marked this conversation as resolved.
Outdated
BaseModel::unload();
}

} // namespace rnexecutorch::models::llm
4 changes: 4 additions & 0 deletions packages/react-native-executorch/src/controllers/LLMController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,10 @@ export class LLMController {
await ResourceFetcher.fs.readAsString(tokenizerConfigPath!)
);

if (this.nativeModule) {
this.nativeModule.unload();
}

this.nativeModule = await global.loadLLM(
modelPath,
tokenizerPath,
Expand Down
Loading